From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
syzbot+87a05ae4accd500f5242@syzkaller.appspotmail.com,
ak@linux.intel.com, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Linux-MM <linux-mm@kvack.org>,
mawilcox@microsoft.com, mgorman@techsingularity.net,
syzkaller-bugs@googlegroups.com, tim.c.chen@linux.intel.com,
zwisler@kernel.org, willy@infradead.org
Subject: Re: linux-next test error
Date: Wed, 5 Sep 2018 09:34:59 -0400 [thread overview]
Message-ID: <20180905133459.GF23909@thunk.org> (raw)
In-Reply-To: <CAFqt6zZtjPFdfAGxp43oqN3=z9+vAGzdOvDcgFaU+05ffCGu7A@mail.gmail.com>
On Wed, Sep 05, 2018 at 03:20:16PM +0530, Souptick Joarder wrote:
>
> "fs: convert return type int to vm_fault_t" is still under
> review/discusson and not yet merge
> into linux-next. I am not seeing it into linux-next tree.Can you
> please share the commit id ?
It's at: 83c0adddcc6ed128168e7b87eaed0c21eac908e4 in the Linux Next
branch.
Dmitry, can you try reverting this commit and see if it makes the
problem go away?
Souptick, can we just NACK this patch and completely drop it from all
trees?
I think we need to be a *lot* more careful about this vm_fault_t patch
thing. If you can't be bothered to run xfstests, we need to introduce
a new function which replaces block_page_mkwrite() --- and then let
each file system try to convert over to it at their own pace, after
they've done regression testing.
- Ted
next prev parent reply other threads:[~2018-09-05 13:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 7:13 linux-next test error syzbot
2018-09-05 7:17 ` Dmitry Vyukov
2018-09-05 8:55 ` Jan Kara
2018-09-05 9:50 ` Souptick Joarder
2018-09-05 9:53 ` Dmitry Vyukov
2018-09-05 9:57 ` Dmitry Vyukov
2018-09-05 13:34 ` Theodore Y. Ts'o [this message]
2018-09-05 18:44 ` Christoph Hellwig
2018-09-05 19:24 ` Souptick Joarder
2018-09-06 8:38 ` Jan Kara
2018-09-06 12:26 ` Souptick Joarder
2018-09-06 13:05 ` Matthew Wilcox
2018-09-06 13:12 ` Theodore Y. Ts'o
2018-09-06 14:07 ` Theodore Y. Ts'o
2018-09-06 16:00 ` Matthew Wilcox
2018-09-05 13:55 ` Jan Kara
2018-09-05 19:07 ` Souptick Joarder
2018-09-06 8:12 ` Jan Kara
2018-09-06 12:02 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905133459.GF23909@thunk.org \
--to=tytso@mit.edu \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mgorman@techsingularity.net \
--cc=syzbot+87a05ae4accd500f5242@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tim.c.chen@linux.intel.com \
--cc=willy@infradead.org \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).