From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by kanga.kvack.org (Postfix) with ESMTP id 9F4508E0001 for ; Tue, 11 Sep 2018 18:02:49 -0400 (EDT) Received: by mail-pl1-f198.google.com with SMTP id s22-v6so12066734plq.21 for ; Tue, 11 Sep 2018 15:02:49 -0700 (PDT) Received: from ipmail01.adl6.internode.on.net (ipmail01.adl6.internode.on.net. [150.101.137.136]) by mx.google.com with ESMTP id w2-v6si22736191pgh.182.2018.09.11.15.02.47 for ; Tue, 11 Sep 2018 15:02:47 -0700 (PDT) Date: Wed, 12 Sep 2018 08:02:44 +1000 From: Dave Chinner Subject: Re: [PATCH v3 2/4] fs: Don't need to put list_lru into its own cacheline Message-ID: <20180911220244.GF5631@dastard> References: <1536693506-11949-1-git-send-email-longman@redhat.com> <1536693506-11949-3-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536693506-11949-3-git-send-email-longman@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Waiman Long Cc: Alexander Viro , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, "Luis R. Rodriguez" , Kees Cook , Linus Torvalds , Jan Kara , "Paul E. McKenney" , Andrew Morton , Ingo Molnar , Miklos Szeredi , Matthew Wilcox , Larry Woodman , James Bottomley , "Wangkai (Kevin C)" , Michal Hocko On Tue, Sep 11, 2018 at 03:18:24PM -0400, Waiman Long wrote: > The list_lru structure is essentially just a pointer to a table of > per-node LRU lists. Even if CONFIG_MEMCG_KMEM is defined, the list > field is just used for LRU list registration and shrinker_id is set > at initialization. Those fields won't need to be touched that often. > > So there is no point to make the list_lru structures to sit in their > own cachelines. > > Signed-off-by: Waiman Long Looks fine. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com