linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: Oscar Salvador <osalvador@techadventures.net>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linuxarm@huawei.com
Subject: Re: Warning after memory hotplug then online.
Date: Mon, 24 Sep 2018 13:54:29 +0100	[thread overview]
Message-ID: <20180924135429.00007adf@huawei.com> (raw)
In-Reply-To: <20180924123917.GA4775@techadventures.net>

On Mon, 24 Sep 2018 14:39:17 +0200
Oscar Salvador <osalvador@techadventures.net> wrote:

> On Mon, Sep 24, 2018 at 01:07:01PM +0100, Jonathan Cameron wrote:
> > 
> > Hi All,
> > 
> > This is with some additional patches on top of the mm tree to support
> > arm64 memory hot plug, but this particular issue doesn't (at first glance)
> > seem to be connected to that.  It's not a recent issue as IIRC I
> > disabled Kconfig for cgroups when starting to work on this some time ago
> > as a quick and dirty work around for this.  
> 
> Hi Jonathan,
> 
> would you mind to describe the steps you are taking?
> You are adding the memory, and then you online it?
> 

Yes. Exactly that. 

I've hacked the efi memory map to give me 8GB of memory to play with.
I then use /sys/devices/system/memory/probe to hot add a section and
online via /sys/devices/nodes/devices/node3/memory80/online

Everything 'works', but this warning occurs.

This is with a forward ported version of the first
lot of hotplug patches that Andrea Reale, Maciej Bielski and Scott Branden 
wrote... (with NUMA and ACPI support added).

https://lkml.org/lkml/2017/4/11/536

Jonathan

      parent reply	other threads:[~2018-09-24 12:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 12:07 Warning after memory hotplug then online Jonathan Cameron
2018-09-24 12:39 ` Oscar Salvador
2018-09-24 12:42   ` Oscar Salvador
2018-09-24 15:32     ` Jonathan Cameron
2018-09-24 12:54   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180924135429.00007adf@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxarm@huawei.com \
    --cc=osalvador@techadventures.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).