linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Ashish Mhetre <amhetre@nvidia.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, vdumpa@nvidia.com,
	Snikam@nvidia.com, Sri Krishna chowdary <schowdary@nvidia.com>
Subject: Re: [PATCH] mm: Avoid swapping in interrupt context
Date: Tue, 2 Oct 2018 16:54:02 +0900	[thread overview]
Message-ID: <20181002075402.GI598@jagdpanzerIV> (raw)
In-Reply-To: <1538387115-2363-1-git-send-email-amhetre@nvidia.com>

On (10/01/18 15:15), Ashish Mhetre wrote:
> From: Sri Krishna chowdary <schowdary@nvidia.com>
> 
> Pages can be swapped out from interrupt context as well.

Well, if you do kmalloc(GFP_KERNEL) from IRQ then that's the bug
you need to fix in the first place.

> ZRAM uses zsmalloc allocator to make room for these pages.
> 
> But zsmalloc is not made to be used from interrupt context.
> This can result in a kernel Oops.

Most like not just "can" but "will" result in panic(). We have
BUG_ON(in_interrupt()) in zsmalloc.

	-ss

      parent reply	other threads:[~2018-10-02  7:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-01  9:45 [PATCH] mm: Avoid swapping in interrupt context Ashish Mhetre
2018-10-01 12:24 ` Michal Hocko
2018-10-03 10:48   ` Ashish Mhetre
2018-10-03 11:01     ` Michal Hocko
2018-10-03 11:50       ` Ashish Mhetre
2018-10-03 11:53         ` Michal Hocko
2018-10-16  9:35           ` Ashish Mhetre
2018-10-02  7:54 ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002075402.GI598@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=Snikam@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=amhetre@nvidia.com \
    --cc=linux-mm@kvack.org \
    --cc=schowdary@nvidia.com \
    --cc=vdumpa@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).