From: Michal Hocko <mhocko@kernel.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, punit.agrawal@arm.com,
will.deacon@arm.com, Steven.Price@arm.com,
catalin.marinas@arm.com, mike.kravetz@oracle.com,
n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration
Date: Wed, 3 Oct 2018 13:27:58 +0200 [thread overview]
Message-ID: <20181003112758.GC4714@dhcp22.suse.cz> (raw)
In-Reply-To: <789784ee-4830-753b-5d14-f5c7d90622c4@arm.com>
On Wed 03-10-18 12:17:52, Suzuki K Poulose wrote:
[...]
> I have been under the idea that all the checks at the same level could
> have the same indentation. (i.e, 2 tabs in this case for each). Looks
> like there is no rule about it. How about replacing it with a
> switch..case ?
I would simply follow the existing indentation style in that function.
Is this really worth discussig, anyway? Does the proposed change makes
the code harder to read?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-10-03 11:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 12:15 [PATCH 0/4] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-02 12:15 ` [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration Anshuman Khandual
2018-10-02 12:38 ` Suzuki K Poulose
2018-10-02 12:56 ` Anshuman Khandual
2018-10-03 10:22 ` Suzuki K Poulose
2018-10-03 11:10 ` Anshuman Khandual
2018-10-03 11:17 ` Suzuki K Poulose
2018-10-03 11:27 ` Michal Hocko [this message]
2018-10-02 12:39 ` Michal Hocko
2018-10-03 2:16 ` Anshuman Khandual
2018-10-03 6:58 ` Michal Hocko
2018-10-03 9:58 ` Anshuman Khandual
2018-10-03 10:59 ` Michal Hocko
2018-10-03 11:37 ` Anshuman Khandual
2018-10-03 11:48 ` Michal Hocko
2018-10-03 13:06 ` Anshuman Khandual
2018-10-03 13:36 ` Michal Hocko
2018-10-05 7:34 ` Anshuman Khandual
2018-10-09 14:14 ` Michal Hocko
2018-10-10 3:09 ` Anshuman Khandual
2018-10-10 9:39 ` Michal Hocko
2018-10-11 3:16 ` Anshuman Khandual
2018-10-02 12:15 ` [PATCH 2/4] mm/hugetlb: Enable arch specific huge page size support for migration Anshuman Khandual
2018-10-02 12:15 ` [PATCH 3/4] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-02 12:15 ` [PATCH 4/4] arm64/mm: Enable HugeTLB migration for contiguous bit HugeTLB pages Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003112758.GC4714@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=Steven.Price@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=punit.agrawal@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).