From: Oscar Salvador <osalvador@techadventures.net>
To: Masayoshi Mizuma <msys.mizuma@gmail.com>
Cc: linux-mm@kvack.org, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
Michal Hocko <mhocko@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v3 2/3] mm: return zero_resv_unavail optimization
Date: Wed, 10 Oct 2018 11:39:08 +0200 [thread overview]
Message-ID: <20181010093908.GA20663@techadventures.net> (raw)
In-Reply-To: <20181002143821.5112-3-msys.mizuma@gmail.com>
On Tue, Oct 02, 2018 at 10:38:20AM -0400, Masayoshi Mizuma wrote:
> From: Pavel Tatashin <pavel.tatashin@microsoft.com>
>
> When checking for valid pfns in zero_resv_unavail(), it is not necessary to
> verify that pfns within pageblock_nr_pages ranges are valid, only the first
> one needs to be checked. This is because memory for pages are allocated in
> contiguous chunks that contain pageblock_nr_pages struct pages.
>
> Signed-off-by: Pavel Tatashin <pavel.tatashin@microsoft.com>
> Reviewed-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Looks good to me
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Thanks
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2018-10-10 9:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 14:38 [PATCH v3 0/3] mm: Fix for movable_node boot option Masayoshi Mizuma
2018-10-02 14:38 ` [PATCH v3 1/3] mm: zero remaining unavailable struct pages Masayoshi Mizuma
2018-10-10 17:27 ` Pavel Tatashin
2018-10-10 23:29 ` Andrew Morton
2018-10-02 14:38 ` [PATCH v3 2/3] mm: return zero_resv_unavail optimization Masayoshi Mizuma
2018-10-10 9:39 ` Oscar Salvador [this message]
2018-10-02 14:38 ` [PATCH v3 3/3] Revert "x86/e820: put !E820_TYPE_RAM regions into memblock.reserved" Masayoshi Mizuma
2018-10-09 15:14 ` [PATCH v3 0/3] mm: Fix for movable_node boot option Masayoshi Mizuma
2018-10-10 6:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010093908.GA20663@techadventures.net \
--to=osalvador@techadventures.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=msys.mizuma@gmail.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pavel.tatashin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).