From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by kanga.kvack.org (Postfix) with ESMTP id 464816B000D for ; Thu, 11 Oct 2018 09:39:38 -0400 (EDT) Received: by mail-pg1-f200.google.com with SMTP id w15-v6so5987546pge.2 for ; Thu, 11 Oct 2018 06:39:38 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id s203-v6si26463415pgs.499.2018.10.11.06.39.37 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Oct 2018 06:39:37 -0700 (PDT) Date: Thu, 11 Oct 2018 06:39:34 -0700 From: Christoph Hellwig Subject: Re: [PATCH 01/25] xfs: add a per-xfs trace_printk macro Message-ID: <20181011133934.GA23424@infradead.org> References: <153923113649.5546.9840926895953408273.stgit@magnolia> <153923114361.5546.11838344265359068530.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153923114361.5546.11838344265359068530.stgit@magnolia> Sender: owner-linux-mm@kvack.org List-ID: To: "Darrick J. Wong" Cc: david@fromorbit.com, sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com On Wed, Oct 10, 2018 at 09:12:23PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Add a "xfs_tprintk" macro so that developers can use trace_printk to > print out arbitrary debugging information with the XFS device name > attached to the trace output. I can't say I'm a fan of this. trace_printk is a debugging aid, and opencoding the file system name really isn't much of a burden.