From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by kanga.kvack.org (Postfix) with ESMTP id D5E9C6B000C for ; Fri, 12 Oct 2018 07:09:13 -0400 (EDT) Received: by mail-pf1-f198.google.com with SMTP id f4-v6so11153574pff.2 for ; Fri, 12 Oct 2018 04:09:13 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id p18-v6sor730180pgd.43.2018.10.12.04.09.12 for (Google Transport Security); Fri, 12 Oct 2018 04:09:12 -0700 (PDT) Date: Fri, 12 Oct 2018 14:09:06 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions Message-ID: <20181012110906.fpfttp4nhvsr2ps7@kshutemo-mobl1> References: <20181012013756.11285-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> Sender: owner-linux-mm@kvack.org List-ID: To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Michal Hocko , Julia Lawall , elfring@users.sourceforge.net, Andrey Ryabinin , Andy Lutomirski , Borislav Petkov , Catalin Marinas , Chris Zankel , dancol@google.com, Dave Hansen , "David S. Miller" , Fenghua Yu , Geert Uytterhoeven , Guan Xuetao , Helge Deller , hughd@google.com, Ingo Molnar , "James E.J. Bottomley" , Jeff Dike , Jonas Bonn , kasan-dev@googlegroups.com, kvmarm@lists.cs.columbia.edu, Ley Foon Tan , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, pantin@google.com, lokeshgidra@google.com, Max Filippov , minchan@kernel.org, nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, Peter Zijlstra , Richard Weinberger , Rich Felker , Sam Creasey , sparclinux@vger.kernel.org, Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Tony Luck , Will Deacon , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Yoshinori Sato , akpm@linux-foundation.org On Thu, Oct 11, 2018 at 06:37:55PM -0700, Joel Fernandes (Google) wrote: > diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h > index 12fe700632f4..4399d712f6db 100644 > --- a/arch/m68k/include/asm/mcf_pgalloc.h > +++ b/arch/m68k/include/asm/mcf_pgalloc.h > @@ -12,8 +12,7 @@ extern inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte) > > extern const char bad_pmd_string[]; > > -extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm, > - unsigned long address) > +extern inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > { > unsigned long page = __get_free_page(GFP_DMA); > > @@ -32,8 +31,6 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address) > #define pmd_alloc_one_fast(mm, address) ({ BUG(); ((pmd_t *)1); }) > #define pmd_alloc_one(mm, address) ({ BUG(); ((pmd_t *)2); }) > > -#define pte_alloc_one_fast(mm, addr) pte_alloc_one(mm, addr) > - I believe this was one done manually, right? Please explicitely state everthing you did on not of sematic patch ... > diff --git a/arch/microblaze/include/asm/pgalloc.h b/arch/microblaze/include/asm/pgalloc.h > index 7c89390c0c13..f4cc9ffc449e 100644 > --- a/arch/microblaze/include/asm/pgalloc.h > +++ b/arch/microblaze/include/asm/pgalloc.h > @@ -108,10 +108,9 @@ static inline void free_pgd_slow(pgd_t *pgd) > #define pmd_alloc_one_fast(mm, address) ({ BUG(); ((pmd_t *)1); }) > #define pmd_alloc_one(mm, address) ({ BUG(); ((pmd_t *)2); }) > > -extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm, unsigned long addr); > +extern pte_t *pte_alloc_one_kernel(struct mm_struct *mm); > > -static inline struct page *pte_alloc_one(struct mm_struct *mm, > - unsigned long address) > +static inline struct page *pte_alloc_one(struct mm_struct *mm) > { > struct page *ptepage; > > @@ -132,20 +131,6 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm, > return ptepage; > } > > -static inline pte_t *pte_alloc_one_fast(struct mm_struct *mm, > - unsigned long address) > -{ > - unsigned long *ret; > - > - ret = pte_quicklist; > - if (ret != NULL) { > - pte_quicklist = (unsigned long *)(*ret); > - ret[0] = 0; > - pgtable_cache_size--; > - } > - return (pte_t *)ret; > -} > - Ditto. -- Kirill A. Shutemov