From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by kanga.kvack.org (Postfix) with ESMTP id EAA0B6B0010 for ; Wed, 24 Oct 2018 03:52:45 -0400 (EDT) Received: by mail-pf1-f200.google.com with SMTP id n23-v6so2734880pfk.23 for ; Wed, 24 Oct 2018 00:52:45 -0700 (PDT) Received: from mga12.intel.com (mga12.intel.com. [192.55.52.136]) by mx.google.com with ESMTPS id b6-v6si4120276pgi.255.2018.10.24.00.52.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Oct 2018 00:52:44 -0700 (PDT) Date: Wed, 24 Oct 2018 22:32:11 +0800 From: Yi Zhang Subject: Re: [PATCH V5 1/4] kvm: remove redundant reserved page check Message-ID: <20181024143210.GA10874@tiger-server> References: <26f79872e78cc643937059003763b5cfc1333167.1536342881.git.yi.z.zhang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <26f79872e78cc643937059003763b5cfc1333167.1536342881.git.yi.z.zhang@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, yu.c.zhang@intel.com, pagupta@redhat.com, david@redhat.com, jack@suse.cz, hch@lst.de Cc: linux-mm@kvack.org, rkrcmar@redhat.com, jglisse@redhat.com, yi.z.zhang@intel.com On 2018-09-08 at 02:03:28 +0800, Zhang Yi wrote: > PageReserved() is already checked inside kvm_is_reserved_pfn(), > remove it from kvm_set_pfn_dirty(). > > Signed-off-by: Zhang Yi > Signed-off-by: Zhang Yu > Reviewed-by: David Hildenbrand > Acked-by: Pankaj Gupta > --- > virt/kvm/kvm_main.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 8b47507f..c44c406 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -1690,12 +1690,8 @@ EXPORT_SYMBOL_GPL(kvm_release_pfn_dirty); > > void kvm_set_pfn_dirty(kvm_pfn_t pfn) > { > - if (!kvm_is_reserved_pfn(pfn)) { > - struct page *page = pfn_to_page(pfn); > - > - if (!PageReserved(page)) > - SetPageDirty(page); > - } > + if (!kvm_is_reserved_pfn(pfn)) > + SetPageDirty(pfn_to_page(pfn)); > } > EXPORT_SYMBOL_GPL(kvm_set_pfn_dirty); > > -- > 2.7.4 > Hi Paolo, We will remove the reserved flag in dax pages, then patch 2[3,4]/4 is unnecessary, can we queue this 1/4 to next merge? Thank you very much. Yi