From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by kanga.kvack.org (Postfix) with ESMTP id 1290E6B0275 for ; Thu, 25 Oct 2018 05:21:54 -0400 (EDT) Received: by mail-ed1-f71.google.com with SMTP id u6-v6so4304313eds.10 for ; Thu, 25 Oct 2018 02:21:54 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id t9-v6si218459edr.225.2018.10.25.02.21.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 02:21:52 -0700 (PDT) Date: Thu, 25 Oct 2018 11:21:51 +0200 From: Michal Hocko Subject: Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic. Message-ID: <20181025092151.GO18839@dhcp22.suse.cz> References: <1540229092-25207-1-git-send-email-arunks@codeaurora.org> <15247f54-53f3-83d4-6706-e9264b90ca7a@yandex-team.ru> <7a4fcbaee7efb71d2a3c6b403c090db4@codeaurora.org> <20181024061546.GY18839@dhcp22.suse.cz> <0e1fc40af360ed55fd32784f6973af5940232f99.camel@perches.com> <20181024082312.GD18839@dhcp22.suse.cz> <02a1bfc2eed324f3d03aa4a7b5eb6fde4e4a3bdd.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02a1bfc2eed324f3d03aa4a7b5eb6fde4e4a3bdd.camel@perches.com> Sender: owner-linux-mm@kvack.org List-ID: To: Joe Perches Cc: Arun KS , Kees Cook , Konstantin Khlebnikov , LKML , linux-mm , Minchan Kim , Arun Sudhilal , Greg Kroah-Hartman , Andrew Morton On Wed 24-10-18 01:39:18, Joe Perches wrote: > On Wed, 2018-10-24 at 10:23 +0200, Michal Hocko wrote: > > On Tue 23-10-18 23:26:16, Joe Perches wrote: > > > On Wed, 2018-10-24 at 08:15 +0200, Michal Hocko wrote: > > > > On Wed 24-10-18 10:47:52, Arun KS wrote: > > > > > On 2018-10-24 01:34, Kees Cook wrote: > > > > [...] > > > > > > Thank you -- I was struggling to figure out the best way to reply to > > > > > > this. :) > > > > > I'm sorry for the trouble caused. Sent the email using, > > > > > git send-email --to-cmd="scripts/get_maintainer.pl -i" > > > > > 0001-convert-totalram_pages-totalhigh_pages-and-managed_p.patch > > > > > > > > > > Is this not a recommended approach? > > > > > > > > Not really for tree wide mechanical changes. It is much more preferrable > > > > IMHO to only CC people who should review the intention of the change > > > > rather than each and every maintainer whose code is going to be changed. > > > > This is a case by case thing of course but as soon as you see a giant CC > > > > list from get_maintainer.pl then you should try to think twice to use > > > > it. If not sure, just ask on the mailing list. > > > > > > Generally, it's better to use scripts to control > > > the --to-cmd and --cc-cmd options. > > > > I would argue that it is better to use a common sense much more than > > scripts. > > Common sense isn't common. But you cannot replace brain by a script. Again, this is mostly a mechanical change quite internal to the MM proper. Involving all the maintainers which happen to use totalram_pages etc. are unlikely to need to know about this change. Sure there is some chance of merge conflicts and that is where linux-next comes really handy. This is the best advice I can give here. -- Michal Hocko SUSE Labs