From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by kanga.kvack.org (Postfix) with ESMTP id E70C26B1CA0 for ; Mon, 19 Nov 2018 20:43:18 -0500 (EST) Received: by mail-pl1-f198.google.com with SMTP id h10so239525plk.12 for ; Mon, 19 Nov 2018 17:43:18 -0800 (PST) Received: from mga05.intel.com (mga05.intel.com. [192.55.52.43]) by mx.google.com with ESMTPS id 16-v6si44895353pfy.64.2018.11.19.17.43.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 17:43:17 -0800 (PST) Date: Tue, 20 Nov 2018 09:43:13 +0800 From: Aaron Lu Subject: Re: [PATCH v2 RESEND 1/2] mm/page_alloc: free order-0 pages through PCP in page_frag_free() Message-ID: <20181120014313.GA10657@intel.com> References: <20181119134834.17765-1-aaron.lu@intel.com> <20181119134834.17765-2-aaron.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Tariq Toukan Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Andrew Morton , =?utf-8?B?UGF3ZcWC?= Staszewski , Jesper Dangaard Brouer , Eric Dumazet , Ilias Apalodimas , Yoel Caspersen , Mel Gorman , Saeed Mahameed , Michal Hocko , Vlastimil Babka , Dave Hansen , Alexander Duyck , Ian Kumlien On Mon, Nov 19, 2018 at 03:00:53PM +0000, Tariq Toukan wrote: > > > On 19/11/2018 3:48 PM, Aaron Lu wrote: > > page_frag_free() calls __free_pages_ok() to free the page back to > > Buddy. This is OK for high order page, but for order-0 pages, it > > misses the optimization opportunity of using Per-Cpu-Pages and can > > cause zone lock contention when called frequently. > > > > PaweA? Staszewski recently shared his result of 'how Linux kernel > > handles normal traffic'[1] and from perf data, Jesper Dangaard Brouer > > found the lock contention comes from page allocator: > > > > mlx5e_poll_tx_cq > > | > > --16.34%--napi_consume_skb > > | > > |--12.65%--__free_pages_ok > > | | > > | --11.86%--free_one_page > > | | > > | |--10.10%--queued_spin_lock_slowpath > > | | > > | --0.65%--_raw_spin_lock > > | > > |--1.55%--page_frag_free > > | > > --1.44%--skb_release_data > > > > Jesper explained how it happened: mlx5 driver RX-page recycle > > mechanism is not effective in this workload and pages have to go > > through the page allocator. The lock contention happens during > > mlx5 DMA TX completion cycle. And the page allocator cannot keep > > up at these speeds.[2] > > > > I thought that __free_pages_ok() are mostly freeing high order > > pages and thought this is an lock contention for high order pages > > but Jesper explained in detail that __free_pages_ok() here are > > actually freeing order-0 pages because mlx5 is using order-0 pages > > to satisfy its page pool allocation request.[3] > > > > The free path as pointed out by Jesper is: > > skb_free_head() > > -> skb_free_frag() > > -> page_frag_free() > > And the pages being freed on this path are order-0 pages. > > > > Fix this by doing similar things as in __page_frag_cache_drain() - > > send the being freed page to PCP if it's an order-0 page, or > > directly to Buddy if it is a high order page. > > > > With this change, PaweA? hasn't noticed lock contention yet in > > his workload and Jesper has noticed a 7% performance improvement > > using a micro benchmark and lock contention is gone. Ilias' test > > on a 'low' speed 1Gbit interface on an cortex-a53 shows ~11% > > performance boost testing with 64byte packets and __free_pages_ok() > > disappeared from perf top. > > > > [1]: https://www.spinics.net/lists/netdev/msg531362.html > > [2]: https://www.spinics.net/lists/netdev/msg531421.html > > [3]: https://www.spinics.net/lists/netdev/msg531556.html > > > > Reported-by: PaweA? Staszewski > > Analysed-by: Jesper Dangaard Brouer > > Acked-by: Vlastimil Babka > > Acked-by: Mel Gorman > > Acked-by: Jesper Dangaard Brouer > > Acked-by: Ilias Apalodimas > > Tested-by: Ilias Apalodimas > > Acked-by: Alexander Duyck > > Acked-by: Tariq Toukan > missing '>' sign in my email tag. Sorry about that, will fix this and resend. > > Signed-off-by: Aaron Lu > > ---