From: Matthew Wilcox <willy@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Yu Zhao <yuzhao@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: fix swap offset when replacing shmem page
Date: Tue, 20 Nov 2018 05:12:47 -0800 [thread overview]
Message-ID: <20181120131247.GA3065@bombadil.infradead.org> (raw)
In-Reply-To: <alpine.LSU.2.11.1811192057490.2185@eggly.anvils>
On Mon, Nov 19, 2018 at 09:07:27PM -0800, Hugh Dickins wrote:
> I don't much like my original use of the name "swap_index", when it was
> not the index in a swapfile (though it was the index in the radix tree);
> but it will become a correct name with your patch.
>
> Though Matthew Wilcox seems to want us to avoid saying "radix tree"...
Naming is hard ... but the Linux radix tree looks almost nothing like
a classic computer science radix tree. If you try to reconcile our
implementation with the wikipedia article on radix trees, you'll get
very confused.
A lot of places where we were saying 'radix tree' in comments should
really have said 'page cache'. So is this a swap cache index? I'm
not really familiar enough with the swapping code to say.
next prev parent reply other threads:[~2018-11-20 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 0:47 [PATCH] mm: fix swap offset when replacing shmem page Yu Zhao
2018-11-19 1:09 ` [PATCH v2] " Yu Zhao
2018-11-19 22:11 ` Hugh Dickins
2018-11-20 1:29 ` Yu Zhao
2018-11-20 5:07 ` Hugh Dickins
2018-11-20 13:12 ` Matthew Wilcox [this message]
2018-11-21 21:54 ` [PATCH v3] mm: use swp_offset as key in shmem_replace_page() Yu Zhao
2018-11-21 22:11 ` Matthew Wilcox
2018-11-22 0:36 ` Hugh Dickins
2018-11-22 5:01 ` Andrew Morton
2018-11-23 20:11 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120131247.GA3065@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).