Re: Make __memblock_free_early a wrapper of memblock_free rather dup it

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 22 Nov 2018 04:01:53 +0000 "Wang, Matt" <Matt.Wang@Dell.com> wrote:

> Subject: [PATCH] Make __memblock_free_early a wrapper of memblock_free rather
>  than dup it
> 
> Signed-off-by: Wentao Wang <witallwang@gmail.com>
> ---
>  mm/memblock.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 9a2d5ae..08bf136 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1546,12 +1546,7 @@ void * __init memblock_alloc_try_nid(
>   */
>  void __init __memblock_free_early(phys_addr_t base, phys_addr_t size)
>  {
> -	phys_addr_t end = base + size - 1;
> -
> -	memblock_dbg("%s: [%pa-%pa] %pF\n",
> -		     __func__, &base, &end, (void *)_RET_IP_);
> -	kmemleak_free_part_phys(base, size);
> -	memblock_remove_range(&memblock.reserved, base, size);
> +	memblock_free(base, size);
>  }

hm, I suppose so.  The debug messaging becomes less informative but the
duplication is indeed irritating and if we really want to show the
different caller info in the messages, we could do it in a smarter
fashion.