From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: zhe.he@windriver.com
Cc: catalin.marinas@arm.com, tglx@linutronix.de, rostedt@goodmis.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v2] kmemleak: Turn kmemleak_lock to raw spinlock on RT
Date: Fri, 23 Nov 2018 10:53:14 +0100 [thread overview]
Message-ID: <20181123095314.hervxkxtqoixovro@linutronix.de> (raw)
In-Reply-To: <1542877459-144382-1-git-send-email-zhe.he@windriver.com>
On 2018-11-22 17:04:19 [+0800], zhe.he@windriver.com wrote:
> From: He Zhe <zhe.he@windriver.com>
>
> kmemleak_lock, as a rwlock on RT, can possibly be held in atomic context and
> causes the follow BUG.
>
> BUG: scheduling while atomic: migration/15/132/0x00000002
…
> Preemption disabled at:
> [<ffffffff8c927c11>] cpu_stopper_thread+0x71/0x100
> CPU: 15 PID: 132 Comm: migration/15 Not tainted 4.19.0-rt1-preempt-rt #1
> Hardware name: Intel Corp. Harcuvar/Server, BIOS HAVLCRB1.X64.0015.D62.1708310404 08/31/2017
> Call Trace:
> dump_stack+0x4f/0x6a
> ? cpu_stopper_thread+0x71/0x100
> __schedule_bug.cold.16+0x38/0x55
> __schedule+0x484/0x6c0
> schedule+0x3d/0xe0
> rt_spin_lock_slowlock_locked+0x118/0x2a0
> rt_spin_lock_slowlock+0x57/0x90
> __rt_spin_lock+0x26/0x30
> __write_rt_lock+0x23/0x1a0
> ? intel_pmu_cpu_dying+0x67/0x70
> rt_write_lock+0x2a/0x30
> find_and_remove_object+0x1e/0x80
> delete_object_full+0x10/0x20
> kmemleak_free+0x32/0x50
> kfree+0x104/0x1f0
> ? x86_pmu_starting_cpu+0x30/0x30
> intel_pmu_cpu_dying+0x67/0x70
> x86_pmu_dying_cpu+0x1a/0x30
> cpuhp_invoke_callback+0x92/0x700
> take_cpu_down+0x70/0xa0
> multi_cpu_stop+0x62/0xc0
> ? cpu_stop_queue_work+0x130/0x130
> cpu_stopper_thread+0x79/0x100
> smpboot_thread_fn+0x20f/0x2d0
> kthread+0x121/0x140
> ? sort_range+0x30/0x30
> ? kthread_park+0x90/0x90
> ret_from_fork+0x35/0x40
If this is the only problem? kfree() from a preempt-disabled section
should cause a warning even without kmemleak.
> And on v4.18 stable tree the following call trace, caused by grabbing
> kmemleak_lock again, is also observed.
>
> kernel BUG at kernel/locking/rtmutex.c:1048!
> invalid opcode: 0000 [#1] PREEMPT SMP PTI
> CPU: 5 PID: 689 Comm: mkfs.ext4 Not tainted 4.18.16-rt9-preempt-rt #1
…
> Call Trace:
> ? preempt_count_add+0x74/0xc0
> rt_spin_lock_slowlock+0x57/0x90
> ? __kernel_text_address+0x12/0x40
> ? __save_stack_trace+0x75/0x100
> __rt_spin_lock+0x26/0x30
> __write_rt_lock+0x23/0x1a0
> rt_write_lock+0x2a/0x30
> create_object+0x17d/0x2b0
…
is this an RT-only problem? Because mainline should not allow read->read
locking or read->write locking for reader-writer locks. If this only
happens on v4.18 and not on v4.19 then something must have fixed it.
Sebastian
next prev parent reply other threads:[~2018-11-23 9:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 9:04 [PATCH v2] kmemleak: Turn kmemleak_lock to raw spinlock on RT zhe.he
2018-11-22 10:16 ` Sebastian Andrzej Siewior
2018-11-23 9:53 ` Sebastian Andrzej Siewior [this message]
2018-11-23 11:02 ` Andrea Parri
2018-11-23 11:06 ` Sebastian Andrzej Siewior
2018-11-23 11:31 ` Catalin Marinas
2018-11-23 15:51 ` Steven Rostedt
2018-11-26 8:40 ` Peter Zijlstra
2018-11-24 14:26 ` He Zhe
2018-11-30 18:19 ` Sebastian Andrzej Siewior
2018-12-05 13:53 ` He Zhe
2018-12-05 19:14 ` Sebastian Andrzej Siewior
2018-12-18 10:51 ` He Zhe
2018-12-18 15:07 ` Catalin Marinas
2018-12-19 15:30 ` Sebastian Andrzej Siewior
2018-12-20 1:46 ` He Zhe
2018-12-18 15:12 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123095314.hervxkxtqoixovro@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).