Re: [PATCH] mm, show_mem: drop pgdat_resize_lock in show_mem()

Wei Yang
2018-11-29T01:52:09Z

On Wed, Nov 28, 2018 at 02:07:51PM -0800, Andrew Morton wrote:
>On Thu, 29 Nov 2018 05:08:15 +0800 Wei Yang <richard.weiyang@gmail.com> wrote:
>
>> Function show_mem() is used to print system memory status when user
>> requires or fail to allocate memory. Generally, this is a best effort
>> information and not willing to affect core mm subsystem.
>>
>> The data protected by pgdat_resize_lock is mostly correct except there is:
>>
>> * page struct defer init
>> * memory hotplug
>
>What is the advantage in doing this? What problem does the taking of
>that lock cause?

Michal and I had a discussion in https://patchwork.kernel.org/patch/10689759/

The purpose of this is to see whehter it is nessary to make
pgdat_resize_lock IRQ context safe. After went through the code, most of
the users are not from IRQ context.

If my understanding is correct, Michal's suggestion is to drop the lock
here. (The second last reply from Michal.)

--
Wei Yang
Help you, Help me