linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: mhocko@suse.com, dave.hansen@intel.com, osalvador@suse.de,
	david@redhat.com
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH v3 2/2] mm, sparse: pass nid instead of pgdat to sparse_add_one_section()
Date: Thu, 29 Nov 2018 23:53:16 +0800	[thread overview]
Message-ID: <20181129155316.8174-2-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20181129155316.8174-1-richard.weiyang@gmail.com>

Since the information needed in sparse_add_one_section() is node id to
allocate proper memory, it is not necessary to pass its pgdat.

This patch changes the prototype of sparse_add_one_section() to pass
node id directly. This is intended to reduce misleading that
sparse_add_one_section() would touch pgdat.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
 include/linux/memory_hotplug.h | 2 +-
 mm/memory_hotplug.c            | 2 +-
 mm/sparse.c                    | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
index 45a5affcab8a..3787d4e913e6 100644
--- a/include/linux/memory_hotplug.h
+++ b/include/linux/memory_hotplug.h
@@ -333,7 +333,7 @@ extern void move_pfn_range_to_zone(struct zone *zone, unsigned long start_pfn,
 		unsigned long nr_pages, struct vmem_altmap *altmap);
 extern int offline_pages(unsigned long start_pfn, unsigned long nr_pages);
 extern bool is_memblock_offlined(struct memory_block *mem);
-extern int sparse_add_one_section(struct pglist_data *pgdat,
+extern int sparse_add_one_section(int nid,
 		unsigned long start_pfn, struct vmem_altmap *altmap);
 extern void sparse_remove_one_section(struct zone *zone, struct mem_section *ms,
 		unsigned long map_offset, struct vmem_altmap *altmap);
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index f626e7e5f57b..5b3a3d7b4466 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -253,7 +253,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn,
 	if (pfn_valid(phys_start_pfn))
 		return -EEXIST;
 
-	ret = sparse_add_one_section(NODE_DATA(nid), phys_start_pfn, altmap);
+	ret = sparse_add_one_section(nid, phys_start_pfn, altmap);
 	if (ret < 0)
 		return ret;
 
diff --git a/mm/sparse.c b/mm/sparse.c
index 5825f276485f..2472bf23278a 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -662,7 +662,7 @@ static void free_map_bootmem(struct page *memmap)
  * set.  If this is <=0, then that means that the passed-in
  * map was not consumed and must be freed.
  */
-int __meminit sparse_add_one_section(struct pglist_data *pgdat,
+int __meminit sparse_add_one_section(int nid,
 		unsigned long start_pfn, struct vmem_altmap *altmap)
 {
 	unsigned long section_nr = pfn_to_section_nr(start_pfn);
@@ -675,11 +675,11 @@ int __meminit sparse_add_one_section(struct pglist_data *pgdat,
 	 * no locking for this, because it does its own
 	 * plus, it does a kmalloc
 	 */
-	ret = sparse_index_init(section_nr, pgdat->node_id);
+	ret = sparse_index_init(section_nr, nid);
 	if (ret < 0 && ret != -EEXIST)
 		return ret;
 	ret = 0;
-	memmap = kmalloc_section_memmap(section_nr, pgdat->node_id, altmap);
+	memmap = kmalloc_section_memmap(section_nr, nid, altmap);
 	if (!memmap)
 		return -ENOMEM;
 	usemap = __kmalloc_section_usemap();
-- 
2.15.1

  reply	other threads:[~2018-11-29 15:53 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  2:36 [PATCH] mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section() Wei Yang
2018-11-27  6:25 ` Michal Hocko
2018-11-27  7:17   ` Dave Hansen
2018-11-27  7:30     ` Michal Hocko
2018-11-27  7:52     ` osalvador
2018-11-27  8:00       ` Michal Hocko
2018-11-27  8:18         ` osalvador
2018-11-28  0:29       ` Wei Yang
2018-11-28  8:19         ` Oscar Salvador
2018-11-28  8:41           ` Wei Yang
2018-11-28  1:01     ` Wei Yang
2018-11-28  8:47       ` Wei Yang
2018-11-28  9:17         ` Wei Yang
2018-11-28 12:34         ` Michal Hocko
2018-11-28  9:12 ` [PATCH v2] " Wei Yang
2018-11-28 10:28   ` David Hildenbrand
2018-11-29  8:54   ` Michal Hocko
2018-11-29  9:29     ` Wei Yang
2018-11-29 15:53   ` [PATCH v3 1/2] " Wei Yang
2018-11-29 15:53     ` Wei Yang [this message]
2018-11-29 16:01       ` [PATCH v3 2/2] mm, sparse: pass nid instead of pgdat to sparse_add_one_section() David Hildenbrand
2018-11-30  1:22         ` Wei Yang
2018-11-30  9:20           ` David Hildenbrand
2018-11-29 17:15       ` Michal Hocko
2018-11-29 23:57         ` Wei Yang
2018-11-29 16:06     ` [PATCH v3 1/2] mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section() David Hildenbrand
2018-11-29 17:17       ` Michal Hocko
2018-11-30  4:28       ` Wei Yang
2018-11-30  9:19         ` David Hildenbrand
2018-11-30  9:52           ` Michal Hocko
2018-12-04  8:53             ` Wei Yang
2018-12-01  0:31           ` Wei Yang
2018-12-03 11:25         ` David Hildenbrand
2018-12-03 21:06           ` Wei Yang
2018-11-29 17:14     ` Michal Hocko
2018-12-04  8:56     ` [PATCH v4 " Wei Yang
2018-12-04  8:56       ` [PATCH v4 2/2] mm, sparse: pass nid instead of pgdat to sparse_add_one_section() Wei Yang
2018-12-04  9:24       ` [PATCH v4 1/2] mm, sparse: drop pgdat_resize_lock in sparse_add/remove_one_section() David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129155316.8174-2-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).