From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by kanga.kvack.org (Postfix) with ESMTP id 5A0216B76C8 for ; Wed, 5 Dec 2018 18:04:19 -0500 (EST) Received: by mail-qt1-f198.google.com with SMTP id p24so22427755qtl.2 for ; Wed, 05 Dec 2018 15:04:19 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id s128si1891209qkb.115.2018.12.05.15.04.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 15:04:18 -0800 (PST) Date: Wed, 5 Dec 2018 18:04:13 -0500 From: Jerome Glisse Subject: Re: [PATCH v2 1/3] mm/mmu_notifier: use structure for invalidate_range_start/end callback Message-ID: <20181205230413.GN3536@redhat.com> References: <20181205053628.3210-1-jglisse@redhat.com> <20181205053628.3210-2-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: "Kuehling, Felix" Cc: "linux-mm@kvack.org" , Andrew Morton , "linux-kernel@vger.kernel.org" , Matthew Wilcox , Ross Zwisler , Jan Kara , Dan Williams , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Michal Hocko , "Koenig, Christian" , Ralph Campbell , John Hubbard , "kvm@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-rdma@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" On Wed, Dec 05, 2018 at 09:42:45PM +0000, Kuehling, Felix wrote: > The amdgpu part looks good to me. > > A minor nit-pick in mmu_notifier.c (inline). > > Either way, the series is Acked-by: Felix Kuehling > > On 2018-12-05 12:36 a.m., jglisse@redhat.com wrote: > > From: Jérôme Glisse > > > > To avoid having to change many callback definition everytime we want > > to add a parameter use a structure to group all parameters for the > > mmu_notifier invalidate_range_start/end callback. No functional changes > > with this patch. > > > > Signed-off-by: Jérôme Glisse > > Cc: Andrew Morton > > Cc: Matthew Wilcox > > Cc: Ross Zwisler > > Cc: Jan Kara > > Cc: Dan Williams > > Cc: Paolo Bonzini > > Cc: Radim Krčmář > > Cc: Michal Hocko > > Cc: Christian Koenig > > Cc: Felix Kuehling > > Cc: Ralph Campbell > > Cc: John Hubbard > > Cc: kvm@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: linux-rdma@vger.kernel.org > > Cc: linux-fsdevel@vger.kernel.org > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 43 +++++++++++-------------- > > drivers/gpu/drm/i915/i915_gem_userptr.c | 14 ++++---- > > drivers/gpu/drm/radeon/radeon_mn.c | 16 ++++----- > > drivers/infiniband/core/umem_odp.c | 20 +++++------- > > drivers/infiniband/hw/hfi1/mmu_rb.c | 13 +++----- > > drivers/misc/mic/scif/scif_dma.c | 11 ++----- > > drivers/misc/sgi-gru/grutlbpurge.c | 14 ++++---- > > drivers/xen/gntdev.c | 12 +++---- > > include/linux/mmu_notifier.h | 14 +++++--- > > mm/hmm.c | 23 ++++++------- > > mm/mmu_notifier.c | 21 ++++++++++-- > > virt/kvm/kvm_main.c | 14 +++----- > > 12 files changed, 102 insertions(+), 113 deletions(-) > > > [snip] > > diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c > > index 5119ff846769..5f6665ae3ee2 100644 > > --- a/mm/mmu_notifier.c > > +++ b/mm/mmu_notifier.c > > @@ -178,14 +178,20 @@ int __mmu_notifier_invalidate_range_start(struct mm_struct *mm, > > unsigned long start, unsigned long end, > > bool blockable) > > { > > + struct mmu_notifier_range _range, *range = &_range; > > I'm not sure why you need to access _range indirectly through a pointer. > See below. > > > > struct mmu_notifier *mn; > > int ret = 0; > > int id; > > > > + range->blockable = blockable; > > + range->start = start; > > + range->end = end; > > + range->mm = mm; > > This could just assign _range.blockable, _range.start, etc. without the > indirection. Or you could even use an initializer instead: > > struct mmu_notifier_range range = { >     .blockable = blockable, >     .start = start, >     ... > }; > > > > + > > id = srcu_read_lock(&srcu); > > hlist_for_each_entry_rcu(mn, &mm->mmu_notifier_mm->list, hlist) { > > if (mn->ops->invalidate_range_start) { > > - int _ret = mn->ops->invalidate_range_start(mn, mm, start, end, blockable); > > + int _ret = mn->ops->invalidate_range_start(mn, range); > > This could just use &_range without the indirection. > > Same in ..._invalidate_range_end below. So explaination is that this is a temporary step all this code is remove in the second patch. It was done this way in this patch to minimize the diff within the next patch. I did this because i wanted to do the convertion in 2 steps the first step i convert all the listener of mmu notifier and in the second step i convert all the call site that trigger a mmu notifer. I did that to help people reviewing only the part they care about. Apparently it end up confusing people more than it helped :) Do people have strong feeling about getting this code that is deleted in the second patch fix in the first patch anyway ? I can respin if so but i don't see much value in formating code that is deleted in the serie. Thank you for reviewing Cheers, Jérôme