Re: [PATCH v7 02/25] ACPI / APEI: Remove silent flag from ghes_read_estatus()

Borislav Petkov
2018-12-04T11:36:09Z

On Mon, Dec 03, 2018 at 06:05:50PM +0000, James Morse wrote:
> Subsequent patches will split up ghes_read_estatus(), at which
> point passing around the 'silent' flag gets annoying. This is to
> suppress prink() messages, which prior to commit 42a0bb3f7138
> ("printk/nmi: generic solution for safe printk in NMI"), were
> unsafe in NMI context.
>
> This is no longer necessary, remove the flag. printk() messages
> are batched in a per-cpu buffer and printed via irq-work, or a call
> back from panic().
>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> Changes since v6:
> * Moved earlier in the series,
> * Tinkered with the commit message.
> * switched to pr_warn_ratelimited() to shut checkpatch up
>
> shutup checkpatch
> ---
> drivers/acpi/apei/ghes.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)

Reviewed-by: Borislav Petkov <bp@suse.de>

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.