Re: [PATCH 6/6] mm: migrate: Drop unused argument of migrate_page_move_mapping()

Jan Kara
2018-12-17T13:17:17Z

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

On Thu 13-12-18 17:17:46, Jan Kara wrote:
> On Thu 13-12-18 15:35:43, Mel Gorman wrote:
> > On Tue, Dec 11, 2018 at 06:21:43PM +0100, Jan Kara wrote:
> > > All callers of migrate_page_move_mapping() now pass NULL for 'head'
> > > argument. Drop it.
> > >
> > > Signed-off-by: Jan Kara <jack@suse.cz>
> >
> > Acked-by: Mel Gorman <mgorman@suse.de>
>
> Thanks for review Mel! Andrew, can you please pick up the series? Thanks!

Andrew, Mel has spotted a bug in patch 1/6 or this series. Can you please
add the attached fixup to the patch 1? Thanks!

Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

[-- Attachment #2: migratepage-fixup.patch --]
[-- Type: text/x-patch, Size: 435 bytes --]

diff --git a/mm/migrate.c b/mm/migrate.c
index 789c7bc90a0c..816ce10e908f 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -438,7 +438,7 @@ static int expected_page_refs(struct page *page)
*/
expected_count += is_device_private_page(page);
expected_count += is_device_public_page(page);
- if (page->mapping)
+ if (page_mapping(page))
expected_count += hpage_nr_pages(page) + page_has_private(page);

return expected_count;