From: Michal Hocko <mhocko@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Jan Kara <jack@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Matthew Wilcox <willy@infradead.org>,
Vratislav Bendel <vbendel@redhat.com>,
Rafael Aquini <aquini@redhat.com>,
Konstantin Khlebnikov <k.khlebnikov@samsung.com>,
Minchan Kim <minchan@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it
Date: Tue, 29 Jan 2019 08:18:37 +0100 [thread overview]
Message-ID: <20190129071837.GZ18811@dhcp22.suse.cz> (raw)
In-Reply-To: <725cd2b9-984f-d69b-1967-660d32858ce4@redhat.com>
On Mon 28-01-19 22:09:14, David Hildenbrand wrote:
> On 28.01.19 21:19, Michal Hocko wrote:
[...]
> > David, could you reformulate the changelog accordingly please? My ack
> > still holds.
>
> You mean reformulating + resending for stable kernels only?
I would merge your patch even if it doesn't fix any real problem _now_.
If for not other reasons it makes the code less subtle because we no
longer depend on this crazy __PageMovable is special. If the movable
flag is supposed to be synchronized with the page lock then do not do
tricks and make code more robust because the next time somebody would
like to fix up the current semantic he might reintroduce the bug easily.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-01-29 7:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 16:04 [PATCH v1] mm: migrate: don't rely on PageMovable() of newpage after unlocking it David Hildenbrand
2019-01-28 16:04 ` David Hildenbrand
2019-01-28 20:02 ` David Hildenbrand
2019-01-28 20:19 ` Michal Hocko
2019-01-28 21:09 ` David Hildenbrand
2019-01-29 7:18 ` Michal Hocko [this message]
2019-01-29 10:01 ` David Hildenbrand
2019-01-29 23:16 ` Sasha Levin
2019-01-29 23:33 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129071837.GZ18811@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=david@redhat.com \
--cc=jack@suse.cz \
--cc=k.khlebnikov@samsung.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@dominikbrodowski.net \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
--cc=vbendel@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).