From: Andrew Morton <akpm@linux-foundation.org>
To: kbuild test robot <lkp@intel.com>
Cc: Chris Down <chris@chrisdown.name>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 203/305] mm/memcontrol.c:5629:52: error: 'THP_FAULT_ALLOC' undeclared; did you mean 'THP_FILE_ALLOC'?
Date: Thu, 31 Jan 2019 11:07:57 -0800 [thread overview]
Message-ID: <20190131110757.6b975f1e787dc7adf414a162@linux-foundation.org> (raw)
In-Reply-To: <201902010206.hcZ8gj0z%fengguang.wu@intel.com>
On Fri, 1 Feb 2019 02:57:08 +0800 kbuild test robot <lkp@intel.com> wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: a4186de8d65ec2ca6c39070ef1d6795a0b4ffe04
> commit: 471431309f7656128a65d6df0c5c47ed112635a0 [203/305] mm: memcontrol: expose THP events on a per-memcg basis
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 8.2.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 471431309f7656128a65d6df0c5c47ed112635a0
> # save the attached .config to linux build tree
> GCC_VERSION=8.2.0 make.cross ARCH=ia64
>
> All errors (new ones prefixed by >>):
>
> mm/memcontrol.c: In function 'memory_stat_show':
> >> mm/memcontrol.c:5629:52: error: 'THP_FAULT_ALLOC' undeclared (first use in this function); did you mean 'THP_FILE_ALLOC'?
> seq_printf(m, "thp_fault_alloc %lu\n", acc.events[THP_FAULT_ALLOC]);
> ^~~~~~~~~~~~~~~
> THP_FILE_ALLOC
> mm/memcontrol.c:5629:52: note: each undeclared identifier is reported only once for each function it appears in
> >> mm/memcontrol.c:5631:17: error: 'THP_COLLAPSE_ALLOC' undeclared (first use in this function); did you mean 'THP_FILE_ALLOC'?
> acc.events[THP_COLLAPSE_ALLOC]);
> ^~~~~~~~~~~~~~~~~~
> THP_FILE_ALLOC
Thanks. This, I assume:
--- a/mm/memcontrol.c~mm-memcontrol-expose-thp-events-on-a-per-memcg-basis-fix
+++ a/mm/memcontrol.c
@@ -39,6 +39,7 @@
#include <linux/shmem_fs.h>
#include <linux/hugetlb.h>
#include <linux/pagemap.h>
+#include <linux/vm_event_item.h>
#include <linux/smp.h>
#include <linux/page-flags.h>
#include <linux/backing-dev.h>
_
next prev parent reply other threads:[~2019-01-31 19:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 18:57 [mmotm:master 203/305] mm/memcontrol.c:5629:52: error: 'THP_FAULT_ALLOC' undeclared; did you mean 'THP_FILE_ALLOC'? kbuild test robot
2019-01-31 19:07 ` Chris Down
2019-01-31 19:07 ` Andrew Morton [this message]
2019-01-31 19:09 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131110757.6b975f1e787dc7adf414a162@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).