From: Chris Down <chris@chrisdown.name>
To: Linux Memory Management List <linux-mm@kvack.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [mmotm:master 203/305] mm/memcontrol.c:5629:52: error: 'THP_FAULT_ALLOC' undeclared
Date: Thu, 31 Jan 2019 08:37:48 -0500 [thread overview]
Message-ID: <20190131133748.GA28484@chrisdown.name> (raw)
In-Reply-To: <201901312116.bwXU2Jyz%fengguang.wu@intel.com>
kbuild test robot writes:
> mm/memcontrol.c: In function 'memory_stat_show':
>>> mm/memcontrol.c:5629:52: error: 'THP_FAULT_ALLOC' undeclared (first use in this function)
> seq_printf(m, "thp_fault_alloc %lu\n", acc.events[THP_FAULT_ALLOC]);
> ^
> mm/memcontrol.c:5629:52: note: each undeclared identifier is reported only once for each function it appears in
>>> mm/memcontrol.c:5631:17: error: 'THP_COLLAPSE_ALLOC' undeclared (first use in this function)
> acc.events[THP_COLLAPSE_ALLOC]);
Oh, right. Now that we don't define these for ourselves in memcontrol.h any
more and just use the VM definitions, they also need to go in an #ifdef.
Apologies for the noise, I'll add a fixup to guard these in a bit.
prev parent reply other threads:[~2019-01-31 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 13:12 [mmotm:master 203/305] mm/memcontrol.c:5629:52: error: 'THP_FAULT_ALLOC' undeclared kbuild test robot
2019-01-31 13:37 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131133748.GA28484@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).