From: Andrea Arcangeli <aarcange@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Cleanup expected_page_refs()
Date: Thu, 7 Feb 2019 13:33:36 -0500 [thread overview]
Message-ID: <20190207183336.GA28677@redhat.com> (raw)
In-Reply-To: <20190207112314.24872-1-jack@suse.cz>
Hello Jan,
On Thu, Feb 07, 2019 at 12:23:14PM +0100, Jan Kara wrote:
> Andrea has noted that page migration code propagates page_mapping(page)
> through the whole migration stack down to migrate_page() function so it
> seems stupid to then use page_mapping(page) in expected_page_refs()
> instead of passed down 'mapping' argument. I agree so let's make
> expected_page_refs() more in line with the rest of the migration stack.
>
> Suggested-by: Andrea Arcangeli <aarcange@redhat.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> mm/migrate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
Thanks,
Andrea
prev parent reply other threads:[~2019-02-07 18:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 11:23 [PATCH] mm: Cleanup expected_page_refs() Jan Kara
2019-02-07 18:33 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207183336.GA28677@redhat.com \
--to=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).