Re: [PATCH] mm: workingset: replace IRQ-off check with a lockdep assert.

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2324 bytes --]

Hi Sebastian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc4 next-20190211]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sebastian-Andrzej-Siewior/mm-workingset-replace-IRQ-off-check-with-a-lockdep-assert/20190212-001418
config: i386-randconfig-x076-201906 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-20) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   mm/workingset.c: In function 'workingset_update_node':
>> mm/workingset.c:382:2: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_is_held_type'? [-Werror=implicit-function-declaration]
     lockdep_is_held(&mapping->i_pages.xa_lock);
     ^~~~~~~~~~~~~~~
     lockdep_is_held_type
   cc1: some warnings being treated as errors

vim +382 mm/workingset.c

   368	
   369	void workingset_update_node(struct xa_node *node)
   370	{
   371		struct address_space *mapping;
   372	
   373		/*
   374		 * Track non-empty nodes that contain only shadow entries;
   375		 * unlink those that contain pages or are being freed.
   376		 *
   377		 * Avoid acquiring the list_lru lock when the nodes are
   378		 * already where they should be. The list_empty() test is safe
   379		 * as node->private_list is protected by the i_pages lock.
   380		 */
   381		mapping = container_of(node->array, struct address_space, i_pages);
 > 382		lockdep_is_held(&mapping->i_pages.xa_lock);
   383	
   384		if (node->count && node->count == node->nr_values) {
   385			if (list_empty(&node->private_list)) {
   386				list_lru_add(&shadow_nodes, &node->private_list);
   387				__inc_lruvec_page_state(virt_to_page(node),
   388							WORKINGSET_NODES);
   389			}
   390		} else {
   391			if (!list_empty(&node->private_list)) {
   392				list_lru_del(&shadow_nodes, &node->private_list);
   393				__dec_lruvec_page_state(virt_to_page(node),
   394							WORKINGSET_NODES);
   395			}
   396		}
   397	}
   398	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33357 bytes --]