From: Michal Hocko <mhocko@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm,oom: Teach lockdep about oom_lock.
Date: Fri, 8 Mar 2019 16:13:27 +0100 [thread overview]
Message-ID: <20190308151327.GU5232@dhcp22.suse.cz> (raw)
In-Reply-To: <20190308150105.GZ32494@hirez.programming.kicks-ass.net>
On Fri 08-03-19 16:01:05, Peter Zijlstra wrote:
> On Fri, Mar 08, 2019 at 12:58:02PM +0100, Michal Hocko wrote:
> > On Fri 08-03-19 12:54:13, Michal Hocko wrote:
> > > [Cc Petr for the lockdep part - the patch is
> > > http://lkml.kernel.org/r/1552040522-9085-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp]
> >
> > now for real.
>
> That really wants a few more comments; I _think_ it is ok, but *shees*.
It would be also great to pull it out of the code flow and hide it
behind a helper static inline. Something like
lockdep_track_oom_alloc_reentrant or a like.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-03-08 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 10:22 [PATCH] mm,oom: Teach lockdep about oom_lock Tetsuo Handa
2019-03-08 11:03 ` Michal Hocko
2019-03-08 11:29 ` Tetsuo Handa
2019-03-08 11:54 ` Michal Hocko
2019-03-08 11:58 ` Michal Hocko
2019-03-08 15:01 ` Peter Zijlstra
2019-03-08 15:13 ` Michal Hocko [this message]
2019-03-09 6:02 ` Tetsuo Handa
2019-03-11 10:30 ` Michal Hocko
2019-03-12 14:06 ` Tetsuo Handa
2019-03-12 15:31 ` Michal Hocko
2019-03-14 13:55 ` Tetsuo Handa
2019-03-12 8:24 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308151327.GU5232@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).