From: "Tobin C. Harding" <me@tobin.cc>
To: Matthew Wilcox <willy@infradead.org>
Cc: Roman Gushchin <guro@fb.com>,
"Tobin C. Harding" <tobin@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] mm: Use slab_list list_head instead of lru
Date: Tue, 12 Mar 2019 14:53:10 +1100 [thread overview]
Message-ID: <20190312035310.GA29476@eros.localdomain> (raw)
In-Reply-To: <20190312023828.GH19508@bombadil.infradead.org>
On Mon, Mar 11, 2019 at 07:38:28PM -0700, Matthew Wilcox wrote:
> On Tue, Mar 12, 2019 at 12:05:54PM +1100, Tobin C. Harding wrote:
> > > slab_list and lru are in the same bits. Once this patch set is in,
> > > we can remove the enigmatic 'uses lru' comment that I added.
> >
> > Funny you should say this, I came to me today while daydreaming that I
> > should have removed that comment :)
> >
> > I'll remove it in v2.
>
> That's great. BTW, something else you could do to verify this patch
> set is check that the object file is unchanged before/after the patch.
> I tend to use 'objdump -dr' to before.s and after.s and use 'diff'
> to compare the two.
Oh cool, I didn't know to do that. I'm not super familiar with the use
of unions having never had need to use one myself so any other union
related tips you think of please share.
thanks,
Tobin.
next prev parent reply other threads:[~2019-03-12 3:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 1:07 [PATCH 0/4] mm: Use slab_list list_head instead of lru Tobin C. Harding
2019-03-11 1:07 ` [PATCH 1/4] slub: Add comments to endif pre-processor macros Tobin C. Harding
2019-03-11 1:07 ` [PATCH 2/4] slub: Use slab_list instead of lru Tobin C. Harding
2019-03-11 1:07 ` [PATCH 3/4] slab: " Tobin C. Harding
2019-03-11 1:07 ` [PATCH 4/4] slob: " Tobin C. Harding
2019-03-11 20:49 ` [PATCH 0/4] mm: Use slab_list list_head " Roman Gushchin
2019-03-11 23:16 ` Matthew Wilcox
2019-03-12 0:22 ` Roman Gushchin
2019-03-12 1:06 ` Tobin C. Harding
2019-03-12 2:01 ` Tobin C. Harding
2019-03-12 17:19 ` Roman Gushchin
2019-03-12 1:05 ` Tobin C. Harding
2019-03-12 2:38 ` Matthew Wilcox
2019-03-12 3:53 ` Tobin C. Harding [this message]
2019-03-12 17:22 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312035310.GA29476@eros.localdomain \
--to=me@tobin.cc \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tobin@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).