Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment

Baoquan He
2019-03-21T14:19:27Z

On 03/21/19 at 05:19am, William Kucharski wrote:
>
>
> > On Mar 21, 2019, at 4:35 AM, Michal Hocko <mhocko@kernel.org> wrote:
> >
> > I am sorry to be snarky but hasn't this generated way much more email
> > traffic than it really deserves? A simply and trivial clean up in the
> > beginning that was it, right?

Yeah, I'd like to do like this. Will arrange patch and post a new
version. Sorry about the mail bomb to CCed people.

Yet I also would like to hear any suggestion from people who intend to
improve. Discussions make me know more the status of errno than before.

Thank you all for sharing.

>
> That's rather the point; that it did generate a fair amount of email
> traffic indicates it's worthy of at least a passing mention in a
> comment somewhere.

We header files to put errno. Only changing in kernel may cause
difference between it and userspace. I will list each returned value in
code comment and tell what they are meaning in this function, that could
be helpful. Thanks.

usr/include/asm-generic/errno-base.h
include/uapi/asm-generic/errno-base.h