From: Andrew Morton <akpm@linux-foundation.org>
To: Yue Hu <zbestahu@gmail.com>
Cc: iamjoonsoo.kim@lge.com, mingo@kernel.org, vbabka@suse.cz,
rppt@linux.vnet.ibm.com, rdunlap@infradead.org,
linux-mm@kvack.org, huyue2@yulong.com
Subject: Re: [PATCH] mm/cma: fix the bitmap status to show failed allocation reason
Date: Wed, 20 Mar 2019 15:12:45 -0700 [thread overview]
Message-ID: <20190320151245.ff79af49fe364ac01d4edb14@linux-foundation.org> (raw)
In-Reply-To: <20190320060829.9144-1-zbestahu@gmail.com>
On Wed, 20 Mar 2019 14:08:29 +0800 Yue Hu <zbestahu@gmail.com> wrote:
> Currently one bit in cma bitmap represents number of pages rather than
> one page, cma->count means cma size in pages. So to find available pages
> via find_next_zero_bit()/find_next_bit() we should use cma size not in
> pages but in bits although current free pages number is correct due to
> zero value of order_per_bit. Once order_per_bit is changed the bitmap
> status will be incorrect.
When fixing a bug, please always describe the end-user visible runtime
effects of that bug?
next prev parent reply other threads:[~2019-03-20 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 6:08 [PATCH] mm/cma: fix the bitmap status to show failed allocation reason Yue Hu
2019-03-20 22:12 ` Andrew Morton [this message]
2019-03-21 2:17 ` Yue Hu
2019-03-21 2:58 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320151245.ff79af49fe364ac01d4edb14@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=huyue2@yulong.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=vbabka@suse.cz \
--cc=zbestahu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).