From: Chris Down <chris@chrisdown.name>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>, Tejun Heo <tj@kernel.org>,
Roman Gushchin <guro@fb.com>, Dennis Zhou <dennis@kernel.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, kernel-team@fb.com
Subject: Re: [PATCH REBASED] mm, memcg: Make scan aggression always exclude protection
Date: Fri, 22 Mar 2019 22:00:46 +0000 [thread overview]
Message-ID: <20190322220046.GA7667@chrisdown.name> (raw)
In-Reply-To: <20190322131015.05edf9fac014f4cacf10dd2a@linux-foundation.org>
Andrew Morton writes:
>Could you please provide more description of the effect this has upon
>userspace? Preferably in real-world cases. What problems were being
>observed and how does this improve things?
Sure! The previous patch's behaviour isn't so much problematic as it is just
not as featureful as it could be.
This change doesn't change the experience for the user in the normal case too
much. One benefit is that it replaces the (somewhat arbitrary) 100% cutoff with
an indefinite slope, which makes it easier to ballpark a memory.low value.
As well as this, the old methodology doesn't quite apply generically to
machines with varying amounts of physical memory. Let's say we have a top level
cgroup, workload.slice, and another top level cgroup, system-management.slice.
We want to roughly give 12G to system-management.slice, so on a 32GB machine we
set memory.low to 20GB in workload.slice, and on a 64GB machine we set
memory.low to 52GB. However, because these are relative amounts to the total
machine size, while the amount of memory we want to generally be willing to
yield to system.slice is absolute (12G), we end up putting more pressure on
system.slice just because we have a larger machine and a larger workload to
fill it, which seems fairly unintuitive. With this new behaviour, we don't end
up with this unintended side effect.
next prev parent reply other threads:[~2019-03-22 22:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 21:30 [PATCH] mm, memcg: Make scan aggression always exclude protection Chris Down
2019-03-01 0:03 ` Roman Gushchin
2019-03-22 16:03 ` [PATCH REBASED] " Chris Down
2019-03-22 20:10 ` Andrew Morton
2019-03-22 22:00 ` Chris Down [this message]
2019-03-22 22:29 ` Roman Gushchin
2019-03-22 22:49 ` Roman Gushchin
2019-03-22 22:51 ` Chris Down
2019-03-22 22:49 ` Chris Down
2019-03-22 23:01 ` Roman Gushchin
2019-03-22 23:51 ` Chris Down
2019-05-30 6:12 ` Michal Hocko
2019-05-30 6:44 ` Chris Down
2019-05-30 6:51 ` Michal Hocko
2019-05-30 20:52 ` Chris Down
2019-05-31 6:28 ` Michal Hocko
2019-05-31 19:27 ` Chris Down
2019-07-16 17:10 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322220046.GA7667@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dennis@kernel.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).