* Re: [PATCH v1] mm: balloon: drop unused function stubs
2019-03-29 12:26 [PATCH v1] mm: balloon: drop unused function stubs David Hildenbrand
@ 2019-03-29 13:55 ` Mukesh Ojha
2019-03-29 14:12 ` Michael S. Tsirkin
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Mukesh Ojha @ 2019-03-29 13:55 UTC (permalink / raw)
To: David Hildenbrand, linux-kernel
Cc: Konstantin Khlebnikov, Pankaj Gupta, Andrew Morton,
Michael S . Tsirkin, linux-mm
On 3/29/2019 5:56 PM, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] mm: balloon: drop unused function stubs
2019-03-29 12:26 [PATCH v1] mm: balloon: drop unused function stubs David Hildenbrand
2019-03-29 13:55 ` Mukesh Ojha
@ 2019-03-29 14:12 ` Michael S. Tsirkin
2019-04-01 6:05 ` Pankaj Gupta
2019-04-02 18:23 ` Rafael Aquini
3 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2019-03-29 14:12 UTC (permalink / raw)
To: David Hildenbrand
Cc: linux-kernel, Konstantin Khlebnikov, Pankaj Gupta, Andrew Morton,
linux-mm
On Fri, Mar 29, 2019 at 01:26:49PM +0100, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;
> --
> 2.17.2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] mm: balloon: drop unused function stubs
2019-03-29 12:26 [PATCH v1] mm: balloon: drop unused function stubs David Hildenbrand
2019-03-29 13:55 ` Mukesh Ojha
2019-03-29 14:12 ` Michael S. Tsirkin
@ 2019-04-01 6:05 ` Pankaj Gupta
2019-04-02 18:23 ` Rafael Aquini
3 siblings, 0 replies; 5+ messages in thread
From: Pankaj Gupta @ 2019-04-01 6:05 UTC (permalink / raw)
To: David Hildenbrand
Cc: linux-kernel, Konstantin Khlebnikov, Andrew Morton,
Michael S . Tsirkin, linux-mm
>
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h
> b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page
> *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;
> --
> 2.17.2
Looks good to me.
Acked-by: Pankaj Gupta <pagupta@redhat.com>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] mm: balloon: drop unused function stubs
2019-03-29 12:26 [PATCH v1] mm: balloon: drop unused function stubs David Hildenbrand
` (2 preceding siblings ...)
2019-04-01 6:05 ` Pankaj Gupta
@ 2019-04-02 18:23 ` Rafael Aquini
3 siblings, 0 replies; 5+ messages in thread
From: Rafael Aquini @ 2019-04-02 18:23 UTC (permalink / raw)
To: David Hildenbrand
Cc: linux-kernel, Konstantin Khlebnikov, Pankaj Gupta, Andrew Morton,
Michael S . Tsirkin, linux-mm
On Fri, Mar 29, 2019 at 01:26:49PM +0100, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> include/linux/balloon_compaction.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/include/linux/balloon_compaction.h b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
> list_del(&page->lru);
> }
>
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> static inline bool balloon_page_isolate(struct page *page)
> {
> return false;
> --
> 2.17.2
>
Acked-by: Rafael Aquini <aquini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread