linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: trong@android.com
Cc: oberpar@linux.ibm.com, akpm@linux-foundation.org,
	ndesaulniers@google.com, ghackmann@android.com,
	linux-mm@kvack.org, kbuild-all@01.org, rdunlap@infradead.org,
	lkp@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] gcov: fix when CONFIG_MODULES is not set
Date: Wed, 3 Apr 2019 08:27:19 -0700	[thread overview]
Message-ID: <20190403152719.GH22763@bombadil.infradead.org> (raw)
In-Reply-To: <20190402030956.48166-1-trong@android.com>

On Tue, Apr 02, 2019 at 10:09:56AM +0700, trong@android.com wrote:
> From: Tri Vo <trong@android.com>
> 
> Fixes: 8c3d220cb6b5 ("gcov: clang support")

I think this is the wrong fix.  Why not simply:

+++ b/include/linux/module.h
@@ -709,6 +709,11 @@ static inline bool is_module_text_address(unsigned long addr)
        return false;
 }
 
+static inline bool within_module(unsigned long addr, const struct module *mod)
+{
+       return false;
+}
+
 /* Get/put a kernel symbol (calls should be symmetric) */
 #define symbol_get(x) ({ extern typeof(x) x __attribute__((weak)); &(x); })
 #define symbol_put(x) do { } while (0)


  parent reply	other threads:[~2019-04-03 15:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-02  3:09 [PATCH v3] gcov: fix when CONFIG_MODULES is not set trong
2019-04-02  4:47 ` Randy Dunlap
2019-04-03 15:27 ` Matthew Wilcox [this message]
2019-04-05 17:18   ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403152719.GH22763@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=ghackmann@android.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=ndesaulniers@google.com \
    --cc=oberpar@linux.ibm.com \
    --cc=rdunlap@infradead.org \
    --cc=trong@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).