From: Michal Hocko <mhocko@kernel.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Yufen Yu <yuyufen@huawei.com>,
linux-mm@kvack.org, kirill.shutemov@linux.intel.com,
n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH v2] hugetlbfs: fix protential null pointer dereference
Date: Thu, 11 Apr 2019 20:49:20 +0200 [thread overview]
Message-ID: <20190411184920.GF10383@dhcp22.suse.cz> (raw)
In-Reply-To: <ce422d2b-dd9d-e878-750d-499b9a21c847@oracle.com>
On Thu 11-04-19 11:40:02, Mike Kravetz wrote:
> On 4/11/19 11:22 AM, Michal Hocko wrote:
> > On Thu 11-04-19 09:52:45, Mike Kravetz wrote:
> >> Or, do you think that is too much?
> >> Ideally, that comment should have been added as part of 58b6e5e8f1ad
> >> ("hugetlbfs: fix memory leak for resv_map") as it could cause one to wonder
> >> if resv_map could be NULL.
> >
> > I would much rather explain a comment explaining _when_ inode_resv_map
> > might return NULL than add checks just to be sure.
>
> You are right. That would make more sense. It has been a while since I
> looked into that code and unfortunately I did not save notes. I'll do some
> research to come up with an appropriate explanation/comment.
Thanks a lot! This is highly appreciated.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-04-11 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 3:53 [PATCH v2] hugetlbfs: fix protential null pointer dereference Yufen Yu
2019-04-11 8:19 ` Michal Hocko
2019-04-11 16:52 ` Mike Kravetz
2019-04-11 18:22 ` Michal Hocko
2019-04-11 18:40 ` Mike Kravetz
2019-04-11 18:49 ` Michal Hocko [this message]
2019-04-15 10:26 ` William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411184920.GF10383@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).