From: Ingo Molnar <mingo@kernel.org>
To: Chen Zhou <chenzhou10@huawei.com>
Cc: wangkefeng.wang@huawei.com, horms@verge.net.au,
ard.biesheuvel@linaro.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
rppt@linux.ibm.com, linux-mm@kvack.org,
takahiro.akashi@linaro.org, mingo@redhat.com, bp@alien8.de,
ebiederm@xmission.com, kexec@lists.infradead.org,
tglx@linutronix.de, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] x86: kdump: move reserve_crashkernel_low() into kexec_core.c
Date: Fri, 12 Apr 2019 09:00:27 +0200 [thread overview]
Message-ID: <20190412070027.GB129493@gmail.com> (raw)
In-Reply-To: <31b41dcc-0d16-d1d0-bff9-dec3e77515c1@huawei.com>
* Chen Zhou <chenzhou10@huawei.com> wrote:
> Hi Ingo,
>
> On 2019/4/10 15:09, Ingo Molnar wrote:
> >
> > * Chen Zhou <chenzhou10@huawei.com> wrote:
> >
> >> In preparation for supporting more than one crash kernel regions
> >> in arm64 as x86_64 does, move reserve_crashkernel_low() into
> >> kexec/kexec_core.c.
> >>
> >> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> >> ---
> >> arch/x86/include/asm/kexec.h | 3 ++
> >> arch/x86/kernel/setup.c | 66 +++++---------------------------------------
> >> include/linux/kexec.h | 1 +
> >> kernel/kexec_core.c | 53 +++++++++++++++++++++++++++++++++++
> >> 4 files changed, 64 insertions(+), 59 deletions(-)
> >
> > No objections for this to be merged via the ARM tree, as long as x86
> > functionality is kept intact.
>
> This patch has no affect on x86.
In *principle*.
In practice the series does change x86 code:
> >> arch/x86/kernel/setup.c | 66 +++++---------------------------------------
> >> include/linux/kexec.h | 1 +
> >> kernel/kexec_core.c | 53 +++++++++++++++++++++++++++++++++++
which is, *hopefully*, an identity transformation. :-)
I.e. Ack, but only if it doesn't break anything. :-)
Thanks,
Ingo
next prev parent reply other threads:[~2019-04-12 7:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 10:28 [PATCH v3 0/4] support reserving crashkernel above 4G on arm64 kdump Chen Zhou
2019-04-09 10:28 ` [PATCH v3 1/4] x86: kdump: move reserve_crashkernel_low() into kexec_core.c Chen Zhou
2019-04-10 7:09 ` Ingo Molnar
2019-04-11 12:32 ` Chen Zhou
2019-04-12 7:00 ` Ingo Molnar [this message]
2019-04-09 10:28 ` [PATCH v3 2/4] arm64: kdump: support reserving crashkernel above 4G Chen Zhou
2019-04-09 10:28 ` [PATCH v3 3/4] arm64: kdump: support more than one crash kernel regions Chen Zhou
2019-04-10 13:09 ` Mike Rapoport
2019-04-11 12:17 ` Chen Zhou
2019-04-13 8:14 ` Chen Zhou
2019-04-14 12:10 ` Mike Rapoport
2019-04-15 2:05 ` Chen Zhou
2019-04-15 5:04 ` Mike Rapoport
2019-04-14 12:13 ` Mike Rapoport
2019-04-15 2:27 ` Chen Zhou
2019-04-15 4:55 ` Mike Rapoport
2019-04-09 10:28 ` [PATCH v3 4/4] kdump: update Documentation about crashkernel on arm64 Chen Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412070027.GB129493@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenzhou10@huawei.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).