From: Jessica Yu <jeyu@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tri Vo <trong@android.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Greg Hackmann <ghackmann@android.com>,
linux-mm@kvack.org, kbuild-all@01.org,
Randy Dunlap <rdunlap@infradead.org>,
kbuild test robot <lkp@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Petri Gynther <pgynther@google.com>,
willy@infradead.org, Peter Oberparleiter <oberpar@linux.ibm.com>
Subject: Re: [PATCH v2] module: add stubs for within_module functions
Date: Wed, 17 Apr 2019 10:59:52 +0200 [thread overview]
Message-ID: <20190417085952.GB17099@linux-8ccs> (raw)
In-Reply-To: <20190416143813.4bac4f106930f6686164c11b@linux-foundation.org>
+++ Andrew Morton [16/04/19 14:38 -0700]:
>On Tue, 16 Apr 2019 11:56:21 -0700 Tri Vo <trong@android.com> wrote:
>
>> On Tue, Apr 16, 2019 at 10:55 AM Tri Vo <trong@android.com> wrote:
>> >
>> > On Tue, Apr 16, 2019 at 8:21 AM Jessica Yu <jeyu@kernel.org> wrote:
>> > >
>> > > +++ Tri Vo [15/04/19 11:18 -0700]:
>> > > >Provide stubs for within_module_core(), within_module_init(), and
>> > > >within_module() to prevent build errors when !CONFIG_MODULES.
>> > > >
>> > > >v2:
>> > > >- Generalized commit message, as per Jessica.
>> > > >- Stubs for within_module_core() and within_module_init(), as per Nick.
>> > > >
>> > > >Suggested-by: Matthew Wilcox <willy@infradead.org>
>> > > >Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> > > >Reported-by: kbuild test robot <lkp@intel.com>
>> > > >Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
>> > > >Signed-off-by: Tri Vo <trong@android.com>
>> > >
>> > > Applied, thanks!
>> >
>> > Thank you!
>>
>> Andrew,
>> this patch fixes 8c3d220cb6b5 ("gcov: clang support"). Could you
>> re-apply the gcov patch? Sorry, if it's a dumb question. I'm not
>> familiar with how cross-tree patches are handled in Linux.
>
>hm, I wonder what Jessica applied this patch to?
I applied the patch that supplies the missing within_module() stubs to
the modules-next branch (a link to the repo is available in
MAINTAINERS), it's landed in linux-next by now, and it should fix the
build error reported by the kbuild test bot.
Thanks,
Jessica
prev parent reply other threads:[~2019-04-17 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 2:25 [PATCH] module: add stub for within_module Tri Vo
2019-04-08 18:08 ` Nick Desaulniers
2019-04-08 18:11 ` Nick Desaulniers
2019-04-15 14:22 ` Jessica Yu
2019-04-15 18:18 ` [PATCH v2] module: add stubs for within_module functions Tri Vo
2019-04-16 15:21 ` Jessica Yu
2019-04-16 17:55 ` Tri Vo
2019-04-16 18:56 ` Tri Vo
2019-04-16 21:38 ` Andrew Morton
2019-04-17 8:59 ` Jessica Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417085952.GB17099@linux-8ccs \
--to=jeyu@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ghackmann@android.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=ndesaulniers@google.com \
--cc=oberpar@linux.ibm.com \
--cc=pgynther@google.com \
--cc=rdunlap@infradead.org \
--cc=trong@android.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).