From: Mel Gorman <mgorman@techsingularity.net>
To: syzbot <syzbot+d84c80f9fe26a0f7a734@syzkaller.appspotmail.com>
Cc: akpm@linux-foundation.org, aryabinin@virtuozzo.com, cai@lca.pw,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
mhocko@suse.com, syzkaller-bugs@googlegroups.com, vbabka@suse.cz
Subject: Re: BUG: unable to handle kernel paging request in isolate_freepages_block
Date: Thu, 9 May 2019 10:57:24 +0100 [thread overview]
Message-ID: <20190509095724.GG18914@techsingularity.net> (raw)
In-Reply-To: <0000000000003beebd0588492456@google.com>
On Tue, May 07, 2019 at 02:50:05AM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: baf76f0c slip: make slhc_free() silently accept an error p..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=16dbe6cca00000
> kernel config: https://syzkaller.appspot.com/x/.config?x=a42d110b47dd6b36
> dashboard link: https://syzkaller.appspot.com/bug?extid=d84c80f9fe26a0f7a734
> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
>
> Unfortunately, I don't have any reproducer for this crash yet.
>
How reproducible is it and can the following (compile tested only) patch
be tested please? I'm thinking it's a similar class of bug to 6b0868c820ff
("mm/compaction.c: correct zone boundary handling when resetting pageblock
skip hints")
diff --git a/mm/compaction.c b/mm/compaction.c
index 3319e0872d01..ae4d99d31b61 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1228,7 +1228,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn, unsigned long
/* Pageblock boundaries */
start_pfn = pageblock_start_pfn(pfn);
- end_pfn = min(start_pfn + pageblock_nr_pages, zone_end_pfn(cc->zone));
+ end_pfn = min(start_pfn + pageblock_nr_pages, zone_end_pfn(cc->zone) - 1);
/* Scan before */
if (start_pfn != pfn) {
@@ -1239,7 +1239,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn, unsigned long
/* Scan after */
start_pfn = pfn + nr_isolated;
- if (start_pfn != end_pfn)
+ if (start_pfn < end_pfn)
isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false);
/* Skip this pageblock in the future as it's full or nearly full */
next prev parent reply other threads:[~2019-05-09 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 9:50 BUG: unable to handle kernel paging request in isolate_freepages_block syzbot
2019-05-09 9:57 ` Mel Gorman [this message]
2019-05-09 10:11 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509095724.GG18914@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=syzbot+d84c80f9fe26a0f7a734@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).