Re: [PATCH RFC v2 0/4] mm/ksm: add option to automerge VMAs

Michal Hocko
2019-05-15T06:53:19Z

On Wed 15-05-19 08:25:23, Oleksandr Natalenko wrote:
[...]
> > > Please make sure to describe a usecase that warrants adding a new
> > > interface we have to maintain for ever.
>
> I think of two major consumers of this interface:
>
> 1) hosts, that run containers, especially similar ones and especially in
> a trusted environment;
>
> 2) heavy applications, that can be run in multiple instances, not
> limited to opensource ones like Firefox, but also those that cannot be
> modified.

This is way too generic. Please provide something more specific. Ideally
with numbers. Why those usecases cannot use an existing interfaces.
Remember you are trying to add a new user interface which we will have
to maintain for ever.

I will try to comment on the interface itself later. But I have to say
that I am not impressed. Abusing sysfs for per process features is quite
gross to be honest.

--
Michal Hocko
SUSE Labs