From: Mark Rutland <mark.rutland@arm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Anshuman Khandual <anshuman.khandual@arm.com>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@suse.com>, Yu Zhao <yuzhao@google.com>,
linux-mm@kvack.org, Mike Rapoport <rppt@linux.ibm.com>
Subject: Re: [PATCH] mm: treewide: Clarify pgtable_page_{ctor,dtor}() naming
Date: Tue, 11 Jun 2019 10:38:23 +0100 [thread overview]
Message-ID: <20190611093822.GA26409@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20190610130511.310e8d2cc8d6b02b2c3e238d@linux-foundation.org>
On Mon, Jun 10, 2019 at 01:05:11PM -0700, Andrew Morton wrote:
> On Mon, 10 Jun 2019 17:33:54 +0100 Mark Rutland <mark.rutland@arm.com> wrote:
>
> > The naming of pgtable_page_{ctor,dtor}() seems to have confused a few
> > people, and until recently arm64 used these erroneously/pointlessly for
> > other levels of pagetable.
> >
> > To make it incredibly clear that these only apply to the PTE level, and
> > to align with the naming of pgtable_pmd_page_{ctor,dtor}(), let's rename
> > them to pgtable_pte_page_{ctor,dtor}().
> >
> > The bulk of this conversion was performed by the below Coccinelle
> > semantic patch, with manual whitespace fixups applied within macros, and
> > Documentation updated by hand.
>
> eep. I get a spectacular number of rejects thanks to Mike's series
>
> asm-generic-x86-introduce-generic-pte_allocfree_one.patch
> alpha-switch-to-generic-version-of-pte-allocation.patch
> arm-switch-to-generic-version-of-pte-allocation.patch
> arm64-switch-to-generic-version-of-pte-allocation.patch
> csky-switch-to-generic-version-of-pte-allocation.patch
> m68k-sun3-switch-to-generic-version-of-pte-allocation.patch
> mips-switch-to-generic-version-of-pte-allocation.patch
> nds32-switch-to-generic-version-of-pte-allocation.patch
> nios2-switch-to-generic-version-of-pte-allocation.patch
> parisc-switch-to-generic-version-of-pte-allocation.patch
> riscv-switch-to-generic-version-of-pte-allocation.patch
> um-switch-to-generic-version-of-pte-allocation.patch
> unicore32-switch-to-generic-version-of-pte-allocation.patch
>
> But at least they will make your patch smaller!
Aha; thanks for the heads-up!
Given this cleanup isn't urgent, I'll sit on it until the above has
settled.
Mark.
prev parent reply other threads:[~2019-06-11 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 16:33 [PATCH] mm: treewide: Clarify pgtable_page_{ctor,dtor}() naming Mark Rutland
2019-06-10 20:05 ` Andrew Morton
2019-06-11 9:38 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611093822.GA26409@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rppt@linux.ibm.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).