From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Yang Shi <yang.shi@linux.alibaba.com>
Cc: ktkhai@virtuozzo.com, kirill.shutemov@linux.intel.com,
hannes@cmpxchg.org, mhocko@suse.com, hughd@google.com,
shakeelb@google.com, rientjes@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] mm: shrinker: make shrinker not depend on memcg kmem
Date: Wed, 12 Jun 2019 13:11:04 +0300 [thread overview]
Message-ID: <20190612101104.7rmjzmfy5owhqcif@box> (raw)
In-Reply-To: <a8f6f119-fd72-9a93-de99-fc7bea6404c0@linux.alibaba.com>
On Tue, Jun 11, 2019 at 10:07:54PM -0700, Yang Shi wrote:
>
>
> On 6/11/19 7:52 PM, Kirill A. Shutemov wrote:
> > On Fri, Jun 07, 2019 at 02:07:39PM +0800, Yang Shi wrote:
> > > Currently shrinker is just allocated and can work when memcg kmem is
> > > enabled. But, THP deferred split shrinker is not slab shrinker, it
> > > doesn't make too much sense to have such shrinker depend on memcg kmem.
> > > It should be able to reclaim THP even though memcg kmem is disabled.
> > >
> > > Introduce a new shrinker flag, SHRINKER_NONSLAB, for non-slab shrinker,
> > > i.e. THP deferred split shrinker. When memcg kmem is disabled, just
> > > such shrinkers can be called in shrinking memcg slab.
> > Looks like it breaks bisectability. It has to be done before makeing
> > shrinker memcg-aware, hasn't it?
>
> No, it doesn't break bisectability. But, THP shrinker just can be called
> with kmem charge enabled without this patch.
So, if kmem is disabled, it will not be called, right? Then it is
regression in my opinion. This patch has to go in before 2/4.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2019-06-12 10:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 6:07 [v2 PATCH 0/4] Make deferred split shrinker memcg aware Yang Shi
2019-06-07 6:07 ` [PATCH 1/4] mm: thp: extract split_queue_* into a struct Yang Shi
2019-06-07 6:07 ` [PATCH 2/4] mm: thp: make deferred split shrinker memcg aware Yang Shi
2019-06-10 8:21 ` Kirill Tkhai
2019-06-10 17:23 ` Yang Shi
2019-06-12 2:47 ` Kirill A. Shutemov
2019-06-12 5:06 ` Yang Shi
2019-06-12 10:09 ` Kirill A. Shutemov
2019-06-12 17:13 ` Yang Shi
2019-06-07 6:07 ` [PATCH 3/4] mm: thp: remove THP destructor Yang Shi
2019-06-07 6:07 ` [PATCH 4/4] mm: shrinker: make shrinker not depend on memcg kmem Yang Shi
2019-06-12 2:52 ` Kirill A. Shutemov
2019-06-12 5:07 ` Yang Shi
2019-06-12 10:11 ` Kirill A. Shutemov [this message]
2019-06-12 17:20 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612101104.7rmjzmfy5owhqcif@box \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).