public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Andrei Vagin <avagin@gmail.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: WARNING: CPU: 0 PID: 11655 at mm/page_counter.c:62
Date: Wed, 19 Jun 2019 21:19:16 +0000	[thread overview]
Message-ID: <20190619211909.GA20860@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <CANaxB-xz6-uCYbSsSEXn3OScYCfpPwP_DxWdh63d9PuLNkeV5g@mail.gmail.com>

On Tue, Jun 18, 2019 at 07:08:26PM -0700, Andrei Vagin wrote:
> Hello,
> 
> We run CRIU tests on linux-next kernels and today we found this
> warning in the kernel log:

Hello, Andrei!

Can you, please, check if the following patch fixes the problem?

Thanks a lot!

--

diff --git a/mm/slab.h b/mm/slab.h
index a4c9b9d042de..7667dddb6492 100644
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -326,7 +326,8 @@ static __always_inline void memcg_uncharge_slab(struct page *page, int order,
        memcg = READ_ONCE(s->memcg_params.memcg);
        lruvec = mem_cgroup_lruvec(page_pgdat(page), memcg);
        mod_lruvec_state(lruvec, cache_vmstat_idx(s), -(1 << order));
-       memcg_kmem_uncharge_memcg(page, order, memcg);
+       if (!mem_cgroup_is_root(memcg))
+               memcg_kmem_uncharge_memcg(page, order, memcg);
        rcu_read_unlock();
 
        percpu_ref_put_many(&s->memcg_params.refcnt, 1 << order);


  parent reply	other threads:[~2019-06-19 21:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19  2:08 WARNING: CPU: 0 PID: 11655 at mm/page_counter.c:62 Andrei Vagin
2019-06-19  3:41 ` Roman Gushchin
2019-06-19 21:19 ` Roman Gushchin [this message]
2019-06-19 23:41   ` Andrei Vagin
2019-06-20  1:32     ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190619211909.GA20860@castle.DHCP.thefacebook.com \
    --to=guro@fb.com \
    --cc=avagin@gmail.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox