From: Mel Gorman <mgorman@suse.de>
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
jhladky@redhat.com, lvenanci@redhat.com,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH -mm] autonuma: Fix scan period updating
Date: Mon, 24 Jun 2019 15:09:50 +0100 [thread overview]
Message-ID: <20190624140950.GF2947@suse.de> (raw)
In-Reply-To: <20190624025604.30896-1-ying.huang@intel.com>
On Mon, Jun 24, 2019 at 10:56:04AM +0800, Huang Ying wrote:
> The autonuma scan period should be increased (scanning is slowed down)
> if the majority of the page accesses are shared with other processes.
> But in current code, the scan period will be decreased (scanning is
> speeded up) in that situation.
>
> This patch fixes the code. And this has been tested via tracing the
> scan period changing and /proc/vmstat numa_pte_updates counter when
> running a multi-threaded memory accessing program (most memory
> areas are accessed by multiple threads).
>
The patch somewhat flips the logic on whether shared or private is
considered and it's not immediately obvious why that was required. That
aside, other than the impact on numa_pte_updates, what actual
performance difference was measured and on on what workloads?
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2019-06-24 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 2:56 [PATCH -mm] autonuma: Fix scan period updating Huang Ying
2019-06-24 14:09 ` Mel Gorman [this message]
2019-06-25 13:23 ` huang ying
2019-07-03 9:17 ` Mel Gorman
2019-07-04 0:32 ` Huang, Ying
2019-07-12 8:27 ` Mel Gorman
2019-07-12 10:48 ` Huang, Ying
2019-07-12 12:50 ` Mel Gorman
2019-07-15 8:08 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624140950.GF2947@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=jhladky@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lvenanci@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).