Re: [PATCHv2] mm: treewide: Clarify pgtable_page_{ctor,dtor}() naming

Geert Uytterhoeven
2019-07-29T09:35:10Z

On Mon, Jul 22, 2019 at 7:27 PM Mark Rutland <mark.rutland@arm.com> wrote:
> The naming of pgtable_page_{ctor,dtor}() seems to have confused a few
> people, and until recently arm64 used these erroneously/pointlessly for
> other levels of page table.
>
> To make it incredibly clear that these only apply to the PTE level, and
> to align with the naming of pgtable_pmd_page_{ctor,dtor}(), let's rename
> them to pgtable_pte_page_{ctor,dtor}().
>
> These changes were generated with the following shell script:
>
> ----

Using "---" here might lead to the loss of everything below, including
your SoB.

> git grep -lw 'pgtable_page_.tor' | while read FILE; do
> sed -i '{s/pgtable_page_ctor/pgtable_pte_page_ctor/}' $FILE;
> sed -i '{s/pgtable_page_dtor/pgtable_pte_page_dtor/}' $FILE;
> done
> ----
>
> ... with the documentation re-flowed to remain under 80 columns, and
> whitespace fixed up in macros to keep backslashes aligned.
>
> There should be no functional change as a result of this patch.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>

[...]

> arch/m68k/include/asm/mcf_pgalloc.h | 6 +++---
> arch/m68k/include/asm/motorola_pgalloc.h | 6 +++---
> arch/m68k/include/asm/sun3_pgalloc.h | 2 +-

For the m68k changes:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds