From: Mel Gorman <mgorman@suse.de>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hillf Danton <hdanton@sina.com>, Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 2/3] mm, compaction: use MIN_COMPACT_COSTLY_PRIORITY everywhere for costly orders
Date: Thu, 25 Jul 2019 09:06:31 +0100 [thread overview]
Message-ID: <20190725080631.GC2708@suse.de> (raw)
In-Reply-To: <20190724175014.9935-3-mike.kravetz@oracle.com>
On Wed, Jul 24, 2019 at 10:50:13AM -0700, Mike Kravetz wrote:
> For PAGE_ALLOC_COSTLY_ORDER allocations, MIN_COMPACT_COSTLY_PRIORITY is
> minimum (highest priority). Other places in the compaction code key off
> of MIN_COMPACT_PRIORITY. Costly order allocations will never get to
> MIN_COMPACT_PRIORITY. Therefore, some conditions will never be met for
> costly order allocations.
>
> This was observed when hugetlb allocations could stall for minutes or
> hours when should_compact_retry() would return true more often then it
> should. Specifically, this was in the case where compact_result was
> COMPACT_DEFERRED and COMPACT_PARTIAL_SKIPPED and no progress was being
> made.
>
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: Mel Gorman <mgorman@suse.de>
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2019-07-25 8:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 17:50 [RFC PATCH 0/3] fix hugetlb page allocation stalls Mike Kravetz
2019-07-24 17:50 ` [RFC PATCH 1/3] mm, reclaim: make should_continue_reclaim perform dryrun detection Mike Kravetz
2019-07-25 8:05 ` Mel Gorman
2019-07-26 7:40 ` Hillf Danton
2019-07-26 8:12 ` Mel Gorman
2019-07-31 11:08 ` Vlastimil Babka
2019-07-31 12:25 ` Mel Gorman
2019-07-31 21:11 ` Mike Kravetz
2019-08-01 4:22 ` Hillf Danton
2019-08-01 8:44 ` Vlastimil Babka
2019-08-01 3:16 ` Hillf Danton
2019-07-24 17:50 ` [RFC PATCH 2/3] mm, compaction: use MIN_COMPACT_COSTLY_PRIORITY everywhere for costly orders Mike Kravetz
2019-07-25 8:06 ` Mel Gorman [this message]
2019-07-31 12:06 ` Vlastimil Babka
2019-07-31 20:30 ` Mike Kravetz
2019-08-01 13:01 ` Vlastimil Babka
2019-08-01 20:33 ` Mike Kravetz
2019-08-02 10:20 ` Vlastimil Babka
2019-08-02 12:05 ` Vlastimil Babka
2019-08-02 17:44 ` Mike Kravetz
2019-07-24 17:50 ` [RFC PATCH 3/3] hugetlbfs: don't retry when pool page allocations start to fail Mike Kravetz
2019-07-25 8:13 ` Mel Gorman
2019-07-25 17:15 ` Mike Kravetz
2019-07-25 22:43 ` Mel Gorman
2019-07-31 13:23 ` Vlastimil Babka
2019-07-31 21:13 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725080631.GC2708@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).