Re: [PATCH] fork: Improve error message for corrupted page tables

Andrew Morton
2019-08-01T04:21:02Z

On Wed, 31 Jul 2019 15:36:49 -0700 Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> wrote:

> > > +static const char * const resident_page_types[NR_MM_COUNTERS] = {
> > > + "MM_FILEPAGES",
> > > + "MM_ANONPAGES",
> > > + "MM_SWAPENTS",
> > > + "MM_SHMEMPAGES",
> > > +};
> >
> > But please let's not put this in a header file. We're asking the
> > compiler to put a copy of all of this into every compilation unit which
> > includes the header. Presumably the compiler is smart enough not to
> > do that, but it's not good practice.
>
> Thanks for the explanation. Makes sense to me.
>
> Just wanted to check before sending V2,
> Is it OK if I add this to kernel/fork.c? or do you have something else in
> mind?

I was thinking somewhere like mm/util.c so the array could be used by
other code. But it seems there is no such code. Perhaps it's best to
just leave fork.c as it is now.