Re: [RFC PATCH v2 07/19] fs/xfs: Teach xfs to use new dax_layout_busy_page()

Ira Weiny
2019-08-12T18:05:56Z

On Sat, Aug 10, 2019 at 09:30:37AM +1000, Dave Chinner wrote:
> On Fri, Aug 09, 2019 at 03:58:21PM -0700, ira.weiny@intel.com wrote:
> > From: Ira Weiny <ira.weiny@intel.com>
> >
> > dax_layout_busy_page() can now operate on a sub-range of the
> > address_space provided.
> >
> > Have xfs specify the sub range to dax_layout_busy_page()
>
> Hmmm. I've got patches that change all these XFS interfaces to
> support range locks. I'm not sure the way the ranges are passed here
> is the best way to do it, and I suspect they aren't correct in some
> cases, either....
>
> > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> > index ff3c1fae5357..f0de5486f6c1 100644
> > --- a/fs/xfs/xfs_iops.c
> > +++ b/fs/xfs/xfs_iops.c
> > @@ -1042,10 +1042,16 @@ xfs_vn_setattr(
> > xfs_ilock(ip, XFS_MMAPLOCK_EXCL);
> > iolock = XFS_IOLOCK_EXCL | XFS_MMAPLOCK_EXCL;
> >
> > - error = xfs_break_layouts(inode, &iolock, BREAK_UNMAP);
> > - if (error) {
> > - xfs_iunlock(ip, XFS_MMAPLOCK_EXCL);
> > - return error;
> > + if (iattr->ia_size < inode->i_size) {
> > + loff_t off = iattr->ia_size;
> > + loff_t len = inode->i_size - iattr->ia_size;
> > +
> > + error = xfs_break_layouts(inode, &iolock, off, len,
> > + BREAK_UNMAP);
> > + if (error) {
> > + xfs_iunlock(ip, XFS_MMAPLOCK_EXCL);
> > + return error;
> > + }
>
> This isn't right - truncate up still needs to break the layout on
> the last filesystem block of the file,

I'm not following this? From a user perspective they can't have done anything
with the data beyond the EOF. So isn't it safe to allow EOF to grow without
changing the layout of that last block?

> and truncate down needs to
> extend to "maximum file offset" because we remove all extents beyond
> EOF on a truncate down.

Ok, I was trying to allow a user to extend the file without conflicts if they
were to have a pin on the 'beginning' of the original file. This sounds like
you are saying that a layout lease must be dropped to do that? In some ways I
think I understand what you are driving at and I think I see how I may have
been playing "fast and loose" with the strictness of the layout lease. But
from a user perspective if there is a part of the file which "does not exist"
(beyond EOF) does it matter that the layout there may change?

>
> i.e. when we use preallocation, the extent map extends beyond EOF,
> and layout leases need to be able to extend beyond the current EOF
> to allow the lease owner to do extending writes, extending truncate,
> preallocation beyond EOF, etc safely without having to get a new
> lease to cover the new region in the extended file...

I'm not following this. What determines when preallocation is done?

Forgive my ignorance on file systems but how can we have a layout for every
file which is "maximum file offset" for every file even if a file is only 1
page long?

Thanks,
Ira

>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com