From: Michal Hocko <mhocko@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: Yang Shi <yang.shi@linux.alibaba.com>,
Adric Blake <promarbler14@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kirill Tkhai <ktkhai@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Mel Gorman <mgorman@techsingularity.net>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage
Date: Tue, 27 Aug 2019 13:50:14 +0200 [thread overview]
Message-ID: <20190827115014.GZ7538@dhcp22.suse.cz> (raw)
In-Reply-To: <CALOAHbBMWyPBw+Ciup4+YupbLrxcTW76w+Mfc-mGEm9kcWb8YQ@mail.gmail.com>
On Tue 27-08-19 19:43:49, Yafang Shao wrote:
> On Tue, Aug 27, 2019 at 6:43 PM Michal Hocko <mhocko@kernel.org> wrote:
> >
> > If there are no objection to the patch I will post it as a standalong
> > one.
>
> I have no objection to your patch. It could fix the issue.
>
> I still think that it is not proper to use a new scan_control here as
> it breaks the global reclaim context.
>
> This context switch from global reclaim to memcg reclaim is very
> subtle change to the subsequent processing, that may cause some
> unexpected behavior.
Why would it break it? Could you be more specific please?
> Anyway, we can send this patch as a standalong one.
> Feel free to add:
>
> Acked-by: Yafang Shao <laoar.shao@gmail.com>
Thanks!
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2019-08-27 11:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 22:00 WARNINGs in set_task_reclaim_state with memory cgroup and full memory usage Adric Blake
2019-08-24 1:03 ` Yang Shi
2019-08-26 10:55 ` Michal Hocko
2019-08-27 10:43 ` Michal Hocko
2019-08-27 11:43 ` Yafang Shao
2019-08-27 11:50 ` Michal Hocko [this message]
2019-08-27 11:56 ` Yafang Shao
2019-08-27 12:03 ` Michal Hocko
2019-08-27 12:19 ` Yafang Shao
2019-08-27 12:55 ` Michal Hocko
2019-08-27 17:12 ` Yang Shi
-- strict thread matches above, loose matches on Subject: below --
2019-08-24 2:57 Hillf Danton
2019-08-24 3:35 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827115014.GZ7538@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=ktkhai@virtuozzo.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=promarbler14@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox