From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
"Christoph Hellwig" <hch@lst.de>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Thomas Hellström" <thomas@shipmail.org>,
"Jerome Glisse" <jglisse@redhat.com>,
"Steven Price" <steven.price@arm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Thomas Hellstrom" <thellstrom@vmware.com>
Subject: Re: [PATCH 2/3] pagewalk: separate function pointers from iterator data
Date: Mon, 2 Sep 2019 09:58:59 +0200 [thread overview]
Message-ID: <20190902075859.GA29137@lst.de> (raw)
In-Reply-To: <20190902055156.GA24116@mellanox.com>
On Mon, Sep 02, 2019 at 05:51:58AM +0000, Jason Gunthorpe wrote:
> On Sun, Sep 01, 2019 at 01:35:16PM -0700, Guenter Roeck wrote:
> > > I belive the macros above are missing brackets.. Can you confirm the
> > > below takes care of things? I'll add a patch if so
> > >
> >
> > Good catch. Yes, that fixes the build problem.
>
> I added this to the hmm tree to fix it:
This looks good. Although I still haven't figure out how this is
related to the pagewalk changes to start with..
next prev parent reply other threads:[~2019-09-02 7:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 14:19 cleanup the walk_page_range interface v2 Christoph Hellwig
2019-08-28 14:19 ` [PATCH 1/3] mm: split out a new pagewalk.h header from mm.h Christoph Hellwig
2019-08-29 9:05 ` Mike Rapoport
2019-08-29 9:16 ` Steven Price
2019-08-28 14:19 ` [PATCH 2/3] pagewalk: separate function pointers from iterator data Christoph Hellwig
2019-08-28 15:05 ` Jason Gunthorpe
2019-08-29 6:59 ` Christoph Hellwig
2019-09-01 18:45 ` Guenter Roeck
2019-09-01 19:36 ` Jason Gunthorpe
2019-09-01 20:35 ` Guenter Roeck
2019-09-02 5:51 ` Jason Gunthorpe
2019-09-02 7:58 ` Christoph Hellwig [this message]
2019-09-02 10:49 ` Jason Gunthorpe
2019-08-28 14:19 ` [PATCH 3/3] pagewalk: use lockdep_assert_held for locking validation Christoph Hellwig
2019-08-28 15:07 ` cleanup the walk_page_range interface v2 Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902075859.GA29137@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=jgg@mellanox.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@roeck-us.net \
--cc=steven.price@arm.com \
--cc=thellstrom@vmware.com \
--cc=thomas@shipmail.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).