From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org, aarcange@redhat.com, hughd@google.com
Cc: linux-mm@kvack.org, Wei Yang <richardw.yang@linux.intel.com>
Subject: [PATCH 1/2] userfaultfd: remove one unnecessary warn_on in __mcopy_atomic_hugetlb
Date: Wed, 25 Sep 2019 20:18:32 +0800 [thread overview]
Message-ID: <20190925121833.2766-1-richardw.yang@linux.intel.com> (raw)
The warning here is to make sure address(dst_addr) and length(len -
copied) are huge page size aligned.
While this is ensured by:
dst_start and len is huge page size aligned
dst_addr equals to dst_start and increase huge page size each time
copied increase huge page size each time
This means this warning will never be triggered.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
mm/userfaultfd.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
index c7ae74ce5ff3..7895c715000e 100644
--- a/mm/userfaultfd.c
+++ b/mm/userfaultfd.c
@@ -243,10 +243,6 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm,
vm_shared = dst_vma->vm_flags & VM_SHARED;
}
- if (WARN_ON(dst_addr & (vma_hpagesize - 1) ||
- (len - copied) & (vma_hpagesize - 1)))
- goto out_unlock;
-
/*
* If not shared, ensure the dst_vma has a anon_vma.
*/
--
2.17.1
next reply other threads:[~2019-09-25 12:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:18 Wei Yang [this message]
2019-09-25 12:18 ` [PATCH 2/2] userfaultfd: wrap the common dst_vma check into an inlined function Wei Yang
2019-09-25 17:44 ` [PATCH 1/2] userfaultfd: remove one unnecessary warn_on in __mcopy_atomic_hugetlb Mike Kravetz
2019-09-26 0:35 ` Wei Yang
2019-09-26 2:10 ` Mike Kravetz
2019-09-26 2:56 ` Wei Yang
2019-09-26 17:20 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925121833.2766-1-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).