From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D57EAECE589 for ; Fri, 4 Oct 2019 11:36:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8C7FB20867 for ; Fri, 4 Oct 2019 11:36:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="K+HIkB/D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C7FB20867 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 370E86B0007; Fri, 4 Oct 2019 07:36:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 321A06B0008; Fri, 4 Oct 2019 07:36:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20FFE8E0003; Fri, 4 Oct 2019 07:36:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id EF3386B0007 for ; Fri, 4 Oct 2019 07:36:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 83C2B181AC9AE for ; Fri, 4 Oct 2019 11:36:34 +0000 (UTC) X-FDA: 76005899508.01.sheep35_90a8f7764bd49 X-HE-Tag: sheep35_90a8f7764bd49 X-Filterd-Recvd-Size: 4554 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 11:36:33 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id e5so3008153pls.9 for ; Fri, 04 Oct 2019 04:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nOCYZTp0wlW16jrmBzFl+zhQm0PaZWf4IPrpoghz8Yo=; b=K+HIkB/DaYwobnDZtGi3XYvBspVWPMRJiBUETqqpwYTvQp9tFBZOt4UE5me6R4KH5S Mpx9ZDpyd8o1w0mVzmm8xGfSJnTlB+fk7/XqioTy3S4hbK3Z5kH0ZqyrjIOzsB8/tH4D pfUcTKQjyTZzSqwORuc9ZViuQQAwesVIU9ynZ29agbbAhvnjEeoO4Q3XkX0ZgukyrWyx OlvSrz0HxL/0J8NRos64LcHFpCF7MEyzvjVw1ZWrt38q+v1BvfwltyrXUM8IdBp68K2O qjUllfapLPCmx63lB2GJHG7VgeZVpYLRyL6TEoYakOevapQZBNzNwj6pu5yuCvW2iDrV mrHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nOCYZTp0wlW16jrmBzFl+zhQm0PaZWf4IPrpoghz8Yo=; b=mhF436/m+QnFypqkqDXIA0mGi/yRoup8PK0HFKK5S7mJMx9yZaH305LTpZTBWpLR5d WPFnATPC1VMkYulDZ3e9uF1o2+Gk+cAGuW5Mxw5fT3HVDKqJqImeMZ+0fLaXf8sA5dHW jOiGNXSW1n851FLrfoz5CeJwDupHujwANLqG5/xAKKq/T2SnQQHr2BU5w+Xtig4qfWqx KjRpF63P/lhh82dHlcG+b4z/ovXsORejDvRhMjz1juHPx2iectPZ0ktjkL0VbCvxbJ6T WIdOtIakjFhKepkoQENOo/ths/riLYdKKKslUwhmP2d6/2P1LX81Xn0S7JJzp2ScylGc 3iDA== X-Gm-Message-State: APjAAAXyn2iyHQhvI3Xmc4lTKMe/+M0g5HBUF2Mb09wVmGFgdbUfPRmU vqy8MX3VB5JO2gQT/on5w4mGkQ== X-Google-Smtp-Source: APXvYqycHeOHIdMYTzA5mukhrOH4bcwhg8D6NWJcmxV+oLSJ8CZYEOinQHT3+LzyKtJ5O8kGHo7eRg== X-Received: by 2002:a17:902:6b4c:: with SMTP id g12mr15170702plt.80.1570188992416; Fri, 04 Oct 2019 04:36:32 -0700 (PDT) Received: from google.com ([2620:15c:2cd:202:668d:6035:b425:3a3a]) by smtp.gmail.com with ESMTPSA id ev20sm5730991pjb.19.2019.10.04.04.36.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2019 04:36:30 -0700 (PDT) Date: Fri, 4 Oct 2019 04:36:28 -0700 From: Michel Lespinasse To: "Koenig, Christian" Cc: Davidlohr Bueso , "akpm@linux-foundation.org" , "peterz@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "dri-devel@lists.freedesktop.org" , "linux-rdma@vger.kernel.org" , Jerome Glisse , "Deucher, Alexander" , Daniel Vetter , "amd-gfx@lists.freedesktop.org" , Davidlohr Bueso Subject: Re: [PATCH 03/11] drm/amdgpu: convert amdgpu_vm_it to half closed intervals Message-ID: <20191004113628.GA260828@google.com> References: <20191003201858.11666-1-dave@stgolabs.net> <20191003201858.11666-4-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 04, 2019 at 06:54:54AM +0000, Koenig, Christian wrote: > Am 03.10.19 um 22:18 schrieb Davidlohr Bueso: > > The amdgpu_vm interval tree really wants [a, b) intervals, > > NAK, we explicitly do need an [a, b[ interval here. Hi Christian, Just wanted to confirm where you stand on this patch, since I think you reconsidered your initial position after first looking at 9/11 from this series. I do not know the amdgpu code well, but I think the changes should be fine - in struct amdgpu_bo_va_mapping, the "end" field will hold what was previously stored in the "last" field, plus one. The expectation is that overflows should not be an issue there, as "end" is explicitly declared as an uint64, and as the code was previously computing "last + 1" in many places. Does that seem workable to you ? Thanks, -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.