From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06894C4CED1 for ; Fri, 4 Oct 2019 12:10:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B5FBD21D81 for ; Fri, 4 Oct 2019 12:10:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="iTtWj+7g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5FBD21D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5EEA46B0005; Fri, 4 Oct 2019 08:10:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F238E0005; Fri, 4 Oct 2019 08:10:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48EED8E0003; Fri, 4 Oct 2019 08:10:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 297216B0005 for ; Fri, 4 Oct 2019 08:10:27 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id BFD4A181AC9AE for ; Fri, 4 Oct 2019 12:10:26 +0000 (UTC) X-FDA: 76005984852.08.clam35_3d4defb2a058 X-HE-Tag: clam35_3d4defb2a058 X-Filterd-Recvd-Size: 4369 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 12:10:26 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id x10so3667660pgi.5 for ; Fri, 04 Oct 2019 05:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MONUV9NdASv4E/jp3PLYS1e/RNBJIzL7dOLdp6xf/uE=; b=iTtWj+7gGfp6+mPyUyPcmc1lJtdr2PP7Q3oDWr3dme3JCqXTvoY85yKuWWZDqr+5m/ +JsDgV07ki6BMM0hU84es+Tsw9fZruvIti3HHf1SF5iMPnonCoT+VpH54rRIFPHHNVmP 7DslUK3E2axvE6afKEKJW1kJNT76E15ro9GIccWL4y+3c9/AAyvVo/KJypKH8SRfU1WS n5QWt42Atech8fFN7rbGUdWkMprEE3+0ugj2RMeBAK9W1tUJt2muS7tnFG2UFyeVsfyf Qoi6nT5m3WKRNmvn2e0mSyjBD/qHKKVmQMalcby/BF/ww13W9PJX10Y3d9xIyoMIa2cD AEwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MONUV9NdASv4E/jp3PLYS1e/RNBJIzL7dOLdp6xf/uE=; b=KAhpOGOiTjBDSyHBeTpGJV47A5KdeUsEEgYZG6owxIeHG4naPYltfyzQ8MaQpzpnM1 Z7M3ptq4oY3b/tCPZKOy6I/d40CSUT2FAkMSjtWqlhrKMUJvF9mrNk+a/uHZtGcdXfHs ayE7IrQIGBCGDWTVBMhNNu8lx3PGFVoPo0nz4bE5zE4l1mcHMEpF0lFv0Zn6slyg7AaQ 4K/9bkK8Ke67TRgUI0KHPpoEPJm+RQPioCQ7+iPqyfHEbftmulLoTaBjnSAZjbnkpb59 DGev06iNmv5lcyx/0AYjT6zcGumiwlnO43pwyaHH6HwNZJVW6ZGqDnRKO7/Vbdqp46XW LM2g== X-Gm-Message-State: APjAAAV5/vfr+cODx0QIvOU41qqiorxY2BWuLFsE9DRxwraSm6vd5rKB P6N2pJu8JO4ZkY6Ovm3ei9o5nw== X-Google-Smtp-Source: APXvYqzNdLXB1er8H0c7Slwc2yYDYsLUGzWgSjwx36DZdnfkq/ZCVMhUzLC1HtyaiP0lxIoZTRVcSQ== X-Received: by 2002:a63:2154:: with SMTP id s20mr14813025pgm.379.1570191024502; Fri, 04 Oct 2019 05:10:24 -0700 (PDT) Received: from google.com ([2620:15c:2cd:202:668d:6035:b425:3a3a]) by smtp.gmail.com with ESMTPSA id x72sm6836120pfc.89.2019.10.04.05.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2019 05:10:23 -0700 (PDT) Date: Fri, 4 Oct 2019 05:10:21 -0700 From: Michel Lespinasse To: Davidlohr Bueso Cc: akpm@linux-foundation.org, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, Michael@google.com, Jason Wang , virtualization@lists.linux-foundation.org, Davidlohr Bueso Subject: Re: [PATCH 07/11] vhost: convert vhost_umem_interval_tree to half closed intervals Message-ID: <20191004121021.GA4541@google.com> References: <20191003201858.11666-1-dave@stgolabs.net> <20191003201858.11666-8-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191003201858.11666-8-dave@stgolabs.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 03, 2019 at 01:18:54PM -0700, Davidlohr Bueso wrote: > @@ -1320,15 +1320,14 @@ static bool iotlb_access_ok(struct vhost_virtqueue *vq, > { > const struct vhost_umem_node *node; > struct vhost_umem *umem = vq->iotlb; > - u64 s = 0, size, orig_addr = addr, last = addr + len - 1; > + u64 s = 0, size, orig_addr = addr, last = addr + len; maybe "end" or "end_addr" instead of "last". > diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h > index e9ed2722b633..bb36cb9ed5ec 100644 > --- a/drivers/vhost/vhost.h > +++ b/drivers/vhost/vhost.h > @@ -53,13 +53,13 @@ struct vhost_log { > }; > > #define START(node) ((node)->start) > -#define LAST(node) ((node)->last) > +#define END(node) ((node)->end) > > struct vhost_umem_node { > struct rb_node rb; > struct list_head link; > __u64 start; > - __u64 last; > + __u64 end; > __u64 size; > __u64 userspace_addr; > __u32 perm; Preferably also rename __subtree_last to __subtree_end Looks good to me otherwise. -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.