From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE152C4CED1 for ; Fri, 4 Oct 2019 12:30:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A4FD215EA for ; Fri, 4 Oct 2019 12:30:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RizUr5If" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A4FD215EA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0FCDD6B0003; Fri, 4 Oct 2019 08:30:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B06C6B0005; Fri, 4 Oct 2019 08:30:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB7BF8E0003; Fri, 4 Oct 2019 08:30:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id C9CBE6B0003 for ; Fri, 4 Oct 2019 08:30:49 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 7027A8243765 for ; Fri, 4 Oct 2019 12:30:49 +0000 (UTC) X-FDA: 76006036218.24.boys10_2441c91a9d738 X-HE-Tag: boys10_2441c91a9d738 X-Filterd-Recvd-Size: 4026 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 12:30:49 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id 205so3841499pfw.2 for ; Fri, 04 Oct 2019 05:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3h7sOSA5jjR1emcH5dOd6H8xcJkobT200k6X8W+3UrY=; b=RizUr5Ifv1Bz8eqstV0Ksj9u7iT3BnODSB9UF+fHMQWB6OJQT7drjZhpvl+9z5fgF2 saLhn7S19fMY3bByCWvEiDR1zYH0oLs8BXfRNmgdfvGXfz6AIkny2X4q15DuAdRI/ljH d8suc9q/fgiLkaQjRaqqA17Ywqz0XgkG6x9XOFMqr4/Zm4mi1j1dXX/39RO+SNJ+CWhd rAo0bZ5e1ID09f6zmDJ+YvdcLhiSwz/NPyopNmDZAAdhG5nEweJj5/zSexE7mND/m8Wb McPyrdp106HPZnZX4jD8PI5wsew95R4kZjqXT7w1Ty9EEr52H6Zado1HrHQjXf7bDkAC rU3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3h7sOSA5jjR1emcH5dOd6H8xcJkobT200k6X8W+3UrY=; b=rqWudaueJ7bSrnDAd6V0lSeYjluj5M8YCoXzUXnVYkIf/4qBcBYLnv4hOfgLDytbF8 nw0KmzIv5L5s1emosdb2XpQ5aoosW5rGtLwnnu0mAiZeXeHNJtp33nz4e5qZ8aK39C5q 5b+5p7kL51MJGVFBZK3ecGWBAgmdfih743Ubp9yLDj5Df1MxkiPywerCac0NpI0QiTC+ 8PA5rR+6jT0RhZWuFV1cLWPt48h1Z5/38Az+Fc7O3uQ9tNjOCHnYxFjzYfdnsqW9TH6i UI0WGrR4T1XV4j9+CamNfTtbdT+WYsQxrMSl3lOHka2Q7O6P8Sj97BH7Lvu7Vus+6cZr kFdQ== X-Gm-Message-State: APjAAAV/ZqEKmUf8Ps1uIMLunIqfIh3Eji5Y1XT424pcUzkNhhEHJSHJ IXmim2UUGf2IYtSk++eUF8Qvxw== X-Google-Smtp-Source: APXvYqwvpIBZbvlF/CMNVlUL2gBE3HIrXIodkeeSqCAg05vZLgI6flJWYprqy5/q7UrKNdq6z1Qbyw== X-Received: by 2002:a62:5485:: with SMTP id i127mr16750418pfb.260.1570192247465; Fri, 04 Oct 2019 05:30:47 -0700 (PDT) Received: from google.com ([2620:15c:2cd:202:668d:6035:b425:3a3a]) by smtp.gmail.com with ESMTPSA id p1sm8907022pfb.112.2019.10.04.05.30.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2019 05:30:46 -0700 (PDT) Date: Fri, 4 Oct 2019 05:30:44 -0700 From: Michel Lespinasse To: Davidlohr Bueso , Matthew Wilcox Cc: akpm@linux-foundation.org, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, Davidlohr Bueso Subject: Re: [PATCH 08/11] mm: convert vma_interval_tree to half closed intervals Message-ID: <20191004123044.GA11046@google.com> References: <20191003201858.11666-1-dave@stgolabs.net> <20191003201858.11666-9-dave@stgolabs.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191003201858.11666-9-dave@stgolabs.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 03, 2019 at 01:18:55PM -0700, Davidlohr Bueso wrote: > The vma and anon vma interval tree really wants [a, b) intervals, > not fully closed. As such convert it to use the new > interval_tree_gen.h. Because of vma_last_pgoff(), the conversion > is quite straightforward. I am not certain if we need to worry about integer overflow here. The problem case would be accessing the last block of a file that is exactly 16TB long, on an arch where long (and thus pgoff_t) is 32-bit. Maybe FS folks can tell us whether that case is currently supported, or if we can just not worry about it ? I would also want to rename the fields in struct zap_details into start_index and end_index so we can verify we don't leave any off-by-one uses. -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.